data_table: #2 Remove const generics from data table (runtime column count support) by HalavicH · Pull Request #46341 · zed-industries/zed

HalavicH · 2026-01-08T09:23:40Z

This PR removes the const generics limitation from the data table component, enabling tables with a dynamic number of columns determined at runtime.

Context:
This is the next infrastructure step split out from the original CSV preview draft PR. The draft PR remains open as a reference and will continue to be decomposed into smaller, reviewable pieces.

Details:

Introduces a TableRow newtype to enforce column count invariants at runtime, replacing the previous const generic approach. It's api surface is larger than is currently used, as it's planned to be used in CSV feature itself.
Refactors the data table and all usages (including the keymap editor) to work with runtime column counts.
This change is foundational for supporting CSV preview and other features that require flexible, dynamic tables.
Performance impact has not been formally measured, but there is no noticeable slowdown in practice.

Release Notes:

N/A (internal infrastructure change, no user impact)

zed-industries-bot · 2026-01-08T21:30:37Z

	Warnings
⚠️	This PR is missing release notes. Please add a "Release Notes" section that describes the change: `Release Notes: - Added/Fixed/Improved ...` If your change is not user-facing, you can use "N/A" for the entry: `Release Notes: - N/A`

Generated by 🚫 dangerJS against 1c6ff48

Anthony-Eid · 2026-01-08T22:22:38Z

I left the table_row mod in the data table file because it should only be used with a DataTable. Also, when a function takes a window or a context, it should be the last params in the function's signature in that order, except if there's a closure being passed in as well. You can look at gpui functions as an example of this pattern and consistency.

Also, in the future you don't have to leave as many comments describing what code does if the code is simple enough to read. Zed is a code base that changes rapidly and comments can quickly become out of date. Reading the code will always be a source of truth that's reliable.

Besides that this is a high quality PR, and I'm about to enable auto merge! Thank you for contributing.

HalavicH · 2026-01-09T09:59:20Z

Thanks for quick review and feedback! Notes taken

## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [#46341](#46341) - Data table dynamic column support (removed const generics) - [#46190](#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR #44344](#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…dustries#48207) ## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support (removed const generics) - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR zed-industries#44344](zed-industries#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

Extract data table modules into separate files This PR extracts the `tests` and `table_row` modules from `data_table.rs` into separate files to improve code organization. This is preparatory work for the upcoming column width API rework (#2 in the series), where separating mechanical changes from logical changes will make the review easier. The extraction was performed using rust-analyzer's "Extract module to file" command. **Context:** This is part 1 of a 3-PR series improving data table column width handling: 1. **This PR**: Extract modules into separate files (mechanical change) 2. [#51060](#51060) - Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [#46341](#46341) - Data table dynamic column support - [#46190](#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([#48207](#48207)) Release Notes: - N/A

data_table: Replace column width builder API with `ColumnWidthConfig` enum This PR consolidates the data table width configuration API from three separate builder methods (`.column_widths()`, `.resizable_columns()`, `.width()`) into a single `.width_config(ColumnWidthConfig)` call. This makes invalid state combinations unrepresentable and clarifies the two distinct width management modes. **What changed:** - Introduces `ColumnWidthConfig` enum with two variants: - `Static`: Fixed column widths, no resize handles - `Redistributable`: Drag-to-resize columns that redistribute space within a fixed table width - Introduces `TableResizeBehavior` enum (`None`, `Resizable`, `MinSize(f32)`) for per-column resize policy - Renames `TableColumnWidths` → `RedistributableColumnsState` to better reflect its purpose - Extracts all width management logic into a new `width_management.rs` module - Updates all callers: `csv_preview`, `git_graph`, `keymap_editor`, `edit_prediction_context_view` ```rust pub enum ColumnWidthConfig { /// Static column widths (no resize handles). Static { widths: StaticColumnWidths, /// Controls widths of the whole table. table_width: Option<DefiniteLength>, }, /// Redistributable columns — dragging redistributes the fixed available space /// among columns without changing the overall table width. Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength>, }, } ``` **Why:** The old API allowed callers to combine methods incorrectly. The new enum-based design enforces correct usage at compile time and provides a clearer path for adding independently resizable columns in PR #3. **Context:** This is part 2 of a 3-PR series improving data table column width handling: 1. [#51059](#51059) - Extract modules into separate files (mechanical change) 2. **This PR**: Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [#46341](#46341) - Data table dynamic column support - [#46190](#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([#48207](#48207)) ### Anthony's note This PR also fixes the table dividers being a couple pixels off, and the csv preview from having double line rendering for a single column in some cases. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [#51059](#51059) - Extract modules into separate files (mechanical change) 2. [#51120](#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [#46341](#46341) - Data table dynamic column support - [#46190](#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([#48207](#48207)) This work is based on the [original draft PR #44344](#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

data_table: Replace column width builder API with `ColumnWidthConfig` enum This PR consolidates the data table width configuration API from three separate builder methods (`.column_widths()`, `.resizable_columns()`, `.width()`) into a single `.width_config(ColumnWidthConfig)` call. This makes invalid state combinations unrepresentable and clarifies the two distinct width management modes. **What changed:** - Introduces `ColumnWidthConfig` enum with two variants: - `Static`: Fixed column widths, no resize handles - `Redistributable`: Drag-to-resize columns that redistribute space within a fixed table width - Introduces `TableResizeBehavior` enum (`None`, `Resizable`, `MinSize(f32)`) for per-column resize policy - Renames `TableColumnWidths` → `RedistributableColumnsState` to better reflect its purpose - Extracts all width management logic into a new `width_management.rs` module - Updates all callers: `csv_preview`, `git_graph`, `keymap_editor`, `edit_prediction_context_view` ```rust pub enum ColumnWidthConfig { /// Static column widths (no resize handles). Static { widths: StaticColumnWidths, /// Controls widths of the whole table. table_width: Option<DefiniteLength>, }, /// Redistributable columns — dragging redistributes the fixed available space /// among columns without changing the overall table width. Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength>, }, } ``` **Why:** The old API allowed callers to combine methods incorrectly. The new enum-based design enforces correct usage at compile time and provides a clearer path for adding independently resizable columns in PR zed-industries#3. **Context:** This is part 2 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. **This PR**: Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) ### Anthony's note This PR also fixes the table dividers being a couple pixels off, and the csv preview from having double line rendering for a single column in some cases. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. [zed-industries#51120](zed-industries#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) This work is based on the [original draft PR zed-industries#44344](zed-industries#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [#46341](zed-industries/zed#46341) - Data table dynamic column support (removed const generics) - [#46190](zed-industries/zed#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR #44344](zed-industries/zed#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

Extract data table modules into separate files This PR extracts the `tests` and `table_row` modules from `data_table.rs` into separate files to improve code organization. This is preparatory work for the upcoming column width API rework (#2 in the series), where separating mechanical changes from logical changes will make the review easier. The extraction was performed using rust-analyzer's "Extract module to file" command. **Context:** This is part 1 of a 3-PR series improving data table column width handling: 1. **This PR**: Extract modules into separate files (mechanical change) 2. [#51060](zed-industries/zed#51060) - Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [#46341](zed-industries/zed#46341) - Data table dynamic column support - [#46190](zed-industries/zed#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([#48207](zed-industries/zed#48207)) Release Notes: - N/A

data_table: Replace column width builder API with `ColumnWidthConfig` enum This PR consolidates the data table width configuration API from three separate builder methods (`.column_widths()`, `.resizable_columns()`, `.width()`) into a single `.width_config(ColumnWidthConfig)` call. This makes invalid state combinations unrepresentable and clarifies the two distinct width management modes. **What changed:** - Introduces `ColumnWidthConfig` enum with two variants: - `Static`: Fixed column widths, no resize handles - `Redistributable`: Drag-to-resize columns that redistribute space within a fixed table width - Introduces `TableResizeBehavior` enum (`None`, `Resizable`, `MinSize(f32)`) for per-column resize policy - Renames `TableColumnWidths` → `RedistributableColumnsState` to better reflect its purpose - Extracts all width management logic into a new `width_management.rs` module - Updates all callers: `csv_preview`, `git_graph`, `keymap_editor`, `edit_prediction_context_view` ```rust pub enum ColumnWidthConfig { /// Static column widths (no resize handles). Static { widths: StaticColumnWidths, /// Controls widths of the whole table. table_width: Option<DefiniteLength>, }, /// Redistributable columns — dragging redistributes the fixed available space /// among columns without changing the overall table width. Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength>, }, } ``` **Why:** The old API allowed callers to combine methods incorrectly. The new enum-based design enforces correct usage at compile time and provides a clearer path for adding independently resizable columns in PR zed-industries#3. **Context:** This is part 2 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. **This PR**: Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) ### Anthony's note This PR also fixes the table dividers being a couple pixels off, and the csv preview from having double line rendering for a single column in some cases. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. [zed-industries#51120](zed-industries#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) This work is based on the [original draft PR zed-industries#44344](zed-industries#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…ed-industries#46341) This PR removes the const generics limitation from the data table component, enabling tables with a dynamic number of columns determined at runtime. **Context:** This is the next infrastructure step split out from the [original CSV preview draft PR](zed-industries#44344). The draft PR remains open as a reference and will continue to be decomposed into smaller, reviewable pieces. **Details:** - Introduces a `TableRow` newtype to enforce column count invariants at runtime, replacing the previous const generic approach. It's api surface is larger than is currently used, as it's planned to be used in CSV feature itself. - Refactors the data table and all usages (including the keymap editor) to work with runtime column counts. - This change is foundational for supporting CSV preview and other features that require flexible, dynamic tables. - Performance impact has not been formally measured, but there is no noticeable slowdown in practice. --- Release Notes: - N/A (internal infrastructure change, no user impact) --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…dustries#48207) ## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support (removed const generics) - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR zed-industries#44344](zed-industries#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…stries#51059) Extract data table modules into separate files This PR extracts the `tests` and `table_row` modules from `data_table.rs` into separate files to improve code organization. This is preparatory work for the upcoming column width API rework (zed-industries#2 in the series), where separating mechanical changes from logical changes will make the review easier. The extraction was performed using rust-analyzer's "Extract module to file" command. **Context:** This is part 1 of a 3-PR series improving data table column width handling: 1. **This PR**: Extract modules into separate files (mechanical change) 2. [zed-industries#51060](zed-industries#51060) - Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) Release Notes: - N/A

data_table: Replace column width builder API with `ColumnWidthConfig` enum This PR consolidates the data table width configuration API from three separate builder methods (`.column_widths()`, `.resizable_columns()`, `.width()`) into a single `.width_config(ColumnWidthConfig)` call. This makes invalid state combinations unrepresentable and clarifies the two distinct width management modes. **What changed:** - Introduces `ColumnWidthConfig` enum with two variants: - `Static`: Fixed column widths, no resize handles - `Redistributable`: Drag-to-resize columns that redistribute space within a fixed table width - Introduces `TableResizeBehavior` enum (`None`, `Resizable`, `MinSize(f32)`) for per-column resize policy - Renames `TableColumnWidths` → `RedistributableColumnsState` to better reflect its purpose - Extracts all width management logic into a new `width_management.rs` module - Updates all callers: `csv_preview`, `git_graph`, `keymap_editor`, `edit_prediction_context_view` ```rust pub enum ColumnWidthConfig { /// Static column widths (no resize handles). Static { widths: StaticColumnWidths, /// Controls widths of the whole table. table_width: Option<DefiniteLength>, }, /// Redistributable columns — dragging redistributes the fixed available space /// among columns without changing the overall table width. Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength>, }, } ``` **Why:** The old API allowed callers to combine methods incorrectly. The new enum-based design enforces correct usage at compile time and provides a clearer path for adding independently resizable columns in PR zed-industries#3. **Context:** This is part 2 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. **This PR**: Introduce width config enum for redistributable column widths (API rework) 3. Implement independently resizable column widths (new feature) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) ### Anthony's note This PR also fixes the table dividers being a couple pixels off, and the csv preview from having double line rendering for a single column in some cases. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. [zed-industries#51120](zed-industries#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) This work is based on the [original draft PR zed-industries#44344](zed-industries#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…ed-industries#46341) This PR removes the const generics limitation from the data table component, enabling tables with a dynamic number of columns determined at runtime. **Context:** This is the next infrastructure step split out from the [original CSV preview draft PR](zed-industries#44344). The draft PR remains open as a reference and will continue to be decomposed into smaller, reviewable pieces. **Details:** - Introduces a `TableRow` newtype to enforce column count invariants at runtime, replacing the previous const generic approach. It's api surface is larger than is currently used, as it's planned to be used in CSV feature itself. - Refactors the data table and all usages (including the keymap editor) to work with runtime column counts. - This change is foundational for supporting CSV preview and other features that require flexible, dynamic tables. - Performance impact has not been formally measured, but there is no noticeable slowdown in practice. --- Release Notes: - N/A (internal infrastructure change, no user impact) --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

HalavicH added 4 commits January 8, 2026 08:57

feat: Add TableRow newtype to help hold table column count invariant

5a739af

feat: Remove const generics from data table

538bc42

fix: Update keymap editor table creation to not rely on const generics

850c48f

refactor: Update handle renderer

311d573

cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jan 8, 2026

HalavicH marked this pull request as ready for review January 8, 2026 09:33

HalavicH mentioned this pull request Jan 8, 2026

Feat/remove const generics from data table UI component HalavicH/zed#1

Closed

Anthony-Eid added 3 commits January 8, 2026 16:46

Fix failing tests and component preview of data_table

730bba2

Address review

50f8d4d

Some minor clean up

1c6ff48

Anthony-Eid merged commit fa08e50 into zed-industries:main Jan 8, 2026
23 checks passed

HalavicH mentioned this pull request Feb 2, 2026

csv_preview: #1 Add CSV preview with live table view and interactive features #48207

Merged

This was referenced Mar 8, 2026

data_table: #3 Extract table_row & tests modules to separate files #51059

Merged

data_table: #4 Rework column/table width API #51060

Merged

HalavicH mentioned this pull request Apr 7, 2026

data_table: #5 Add independently resizable columns + fix variable list scrolling #53295

Merged

5 tasks

HalavicH mentioned this pull request Apr 9, 2026

csv_preview: #2 Add settings UI panel with debug tools during development #53496

Merged

5 tasks

HalavicH changed the title ~~Remove const generics from data table (runtime column count support)~~ data_table: #2 Remove const generics from data table (runtime column count support) Jul 13, 2026

HalavicH changed the title ~~data_table: #2 Remove const generics from data table (runtime column count support)~~ data_table: [#2/3] Remove const generics from data table (runtime column count support) Jul 13, 2026

HalavicH changed the title ~~data_table: [#2/3] Remove const generics from data table (runtime column count support)~~ data_table: #2 Remove const generics from data table (runtime column count support) Jul 13, 2026

Navigation Menu

Uh oh!

Uh oh!

data_table: #2 Remove const generics from data table (runtime column count support) - #46341

data_table: #2 Remove const generics from data table (runtime column count support)#46341
Anthony-Eid merged 7 commits into
zed-industries:mainfrom
HalavicH:feat/remove-const-generics-from-data-table-ui-component

HalavicH commented Jan 8, 2026 •

edited by Anthony-Eid

Loading

Uh oh!

zed-industries-bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Anthony-Eid commented Jan 8, 2026

Uh oh!

Uh oh!

HalavicH commented Jan 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

HalavicH commented Jan 8, 2026 • edited by Anthony-Eid Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zed-industries-bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anthony-Eid commented Jan 8, 2026

Uh oh!

Uh oh!

HalavicH commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HalavicH commented Jan 8, 2026 •

edited by Anthony-Eid

Loading

zed-industries-bot commented Jan 8, 2026 •

edited

Loading

HalavicH commented Jan 9, 2026 •

edited

Loading