[Reference POC] CSV/TSV preview (Actual development happens in separate PRs)

Cargo.toml

@@ -227,7 +227,7 @@ members = [
     #
 
     "tooling/perf",
-    "tooling/xtask",
+    "tooling/xtask", "crates/csv_preview",
 ]
 default-members = ["crates/zed"]
 
@@ -283,6 +283,7 @@ copilot = { path = "crates/copilot" }
 crashes = { path = "crates/crashes" }
 credentials_provider = { path = "crates/credentials_provider" }
 crossbeam = "0.8.4"
+csv_preview = { path = "crates/csv_preview"}
 dap = { path = "crates/dap" }
 dap_adapters = { path = "crates/dap_adapters" }
 db = { path = "crates/db" }

assets/keymaps/default-linux.json

@@ -1196,6 +1196,30 @@
       "alt-down": "markdown::ScrollDownByItem",
     },
   },
+  {
+    "context": "CsvPreview",
+    "bindings": {
+      "ctrl-c": "csv::CopySelected",
+      "escape": "csv::ClearSelection",
+      "up": "csv::SelectUp",
+      "down": "csv::SelectDown",
+      "left": "csv::SelectLeft",
+      "right": "csv::SelectRight",
+      "shift-up": "csv::ExtendSelectionUp",
+      "shift-down": "csv::ExtendSelectionDown",
+      "shift-left": "csv::ExtendSelectionLeft",
+      "shift-right": "csv::ExtendSelectionRight",
+      "ctrl-a": "csv::SelectAll",
+      "ctrl-up": "csv::SelectAtTopEdge",
+      "ctrl-down": "csv::SelectAtBottomEdge",
+      "ctrl-left": "csv::SelectAtLeftEdge",
+      "ctrl-right": "csv::SelectAtRightEdge",
+      "ctrl-shift-up": "csv::ExtendSelectionToTopEdge",
+      "ctrl-shift-down": "csv::ExtendSelectionToBottomEdge",
+      "ctrl-shift-left": "csv::ExtendSelectionToLeftEdge",
+      "ctrl-shift-right": "csv::ExtendSelectionToRightEdge"
+    }
+  },
   {
     "context": "KeymapEditor",
     "use_key_equivalents": true,

assets/keymaps/default-macos.json

@@ -1298,6 +1298,38 @@
       "alt-down": "markdown::ScrollDownByItem",
     },
   },
+  {
+    "context": "CsvPreview",
+    "bindings": {
+      "cmd-c": "csv::CopySelected",
+      "escape": "csv::ClearSelection",
+      "up": "csv::SelectUp",
+      "down": "csv::SelectDown",
+      "left": "csv::SelectLeft",
+      "right": "csv::SelectRight",
+      "shift-up": "csv::ExtendSelectionUp",
+      "shift-down": "csv::ExtendSelectionDown",
+      "shift-left": "csv::ExtendSelectionLeft",
+      "shift-right": "csv::ExtendSelectionRight",
+      "cmd-a": "csv::SelectAll",
+      "cmd-up": "csv::SelectAtTopEdge",
+      "cmd-down": "csv::SelectAtBottomEdge",
+      "cmd-left": "csv::SelectAtLeftEdge",
+      "cmd-right": "csv::SelectAtRightEdge",
+      "cmd-shift-up": "csv::ExtendSelectionToTopEdge",
+      "cmd-shift-down": "csv::ExtendSelectionToBottomEdge",
+      "cmd-shift-left": "csv::ExtendSelectionToLeftEdge",
+      "cmd-shift-right": "csv::ExtendSelectionToRightEdge",
+      "enter": "csv::StartCellEditing",
+    },
+  },
+  {
+    "context": "TableCellEditor",
+    "bindings": {
+      "enter": "csv::FinishCellEditing",
+      "escape": "csv::CancelCellEditing",
+    },
+  },
   {
     "context": "KeymapEditor",
     "use_key_equivalents": true,

assets/keymaps/default-windows.json

@@ -1225,6 +1225,30 @@
       "alt-down": "markdown::ScrollDownByItem",
     },
   },
+  {
+    "context": "CsvPreview",
+    "bindings": {
+      "ctrl-c": "csv::CopySelected",
+      "escape": "csv::ClearSelection",
+      "up": "csv::SelectUp",
+      "down": "csv::SelectDown",
+      "left": "csv::SelectLeft",
+      "right": "csv::SelectRight",
+      "shift-up": "csv::ExtendSelectionUp",
+      "shift-down": "csv::ExtendSelectionDown",
+      "shift-left": "csv::ExtendSelectionLeft",
+      "shift-right": "csv::ExtendSelectionRight",
+      "ctrl-a": "csv::SelectAll",
+      "ctrl-up": "csv::SelectAtTopEdge",
+      "ctrl-down": "csv::SelectAtBottomEdge",
+      "ctrl-left": "csv::SelectAtLeftEdge",
+      "ctrl-right": "csv::SelectAtRightEdge",
+      "ctrl-shift-up": "csv::ExtendSelectionToTopEdge",
+      "ctrl-shift-down": "csv::ExtendSelectionToBottomEdge",
+      "ctrl-shift-left": "csv::ExtendSelectionToLeftEdge",
+      "ctrl-shift-right": "csv::ExtendSelectionToRightEdge"
+    }
+  },
   {
     "context": "KeymapEditor",
     "use_key_equivalents": true,

crates/csv_preview/Cargo.toml

@@ -0,0 +1,28 @@
+[package]
+name = "csv_preview"
+version = "0.1.0"
+publish.workspace = true
+edition.workspace = true
+
+[lib]
+path = "src/csv_preview.rs"
+doctest = false
+
+[dependencies]
+anyhow.workspace = true
+gpui.workspace = true
+editor.workspace = true
+ui.workspace = true
+workspace.workspace = true
+log.workspace = true
+derive_more.workspace = true
+text.workspace = true
+menu.workspace = true
+
+# Needed to compile fork of `data_table.rs`
+itertools.workspace = true
+ui_macros.workspace = true
+component.workspace = true
+
+[lints]
+workspace = true

crates/csv_preview/LICENCE-GPL

@@ -0,0 +1 @@
+../../LICENSE-GPL

crates/csv_preview/PROGRESS.md

@@ -0,0 +1,147 @@
+# CSV Preview Progress Tracker
+
+This document outlines the current state of the POC feature. It might not be the most understandable document for others, but the feature author depends on it to track progress and ideas.
+
+## Problems to Discuss
+**Data table limitations**:
+- Const generics. Switch to dynamic arrays
+- Awkward table width configuration (can't really make the table wider than parent automatically). If width is set statically to be bigger than the parent, scrolling needs to be enabled separately, despite it's stated, that it should work automatically.
+- Column widths are calculated via %, and not absolute units. This way it's not possible to calculate whole table based on width of each column.
+- Can't pin first column (row numbers). This results in bad UX when scrolling horizontally (row numbers move out of viewport, and it becomes hard to reason about rows)
+
+**Column Resizing Behavior: Current vs. Needed**
+
+- **Current approach:**
+  The data table uses **proportional (fluid) resizing**. When you adjust a column’s width, the space is redistributed among other columns so the overall table width stays the same.
+
+- **Limitations:**
+  - The table’s width cannot be determined by simply summing up individual column widths.
+  - The table cannot naturally expand beyond its parent container.
+  - This makes it difficult to handle CSV files with columns of widely varying content lengths.
+
+- **Desired approach:**
+  **Independent (absolute) resizing**—like in Google Sheets or Excel:
+  - Each column can be resized without affecting others.
+  - The table’s total width grows or shrinks as columns are resized.
+  - This allows the table to expand beyond its parent and enables intuitive horizontal scrolling.
+
+## Progress
+
+### Table: UI/Behavior
+
+**Features:**
+- [x] feat: Smart debouncing (now + cooldown instead of dumb waiting)
+- [x] feat: Add tooltip to show full value on hover
+- [x] feat: Add performance metrics (timings for sorting, parsing, copying, selection, etc)
+- [ ] feat: Add multiline cells (variable list) / single line cells (unified list) modes
+- [ ] feat: Optional headers (c1 c2 c3) toggle
+- [ ] feat: Horizontal scroll vs fit all columns (**need infra**)
+- [ ] feat: Update column resizing behavior (double-click column boundary to fit to content, again to fit to column name, again to reset)
+- [ ] feat: Add persisting of the state of opened previews on editor restart
+- [ ] feat: Add `CsvPreviewView` settings persistence (probably need to add them to settings.json)
+- [ ] feat: Generalize the preview to support .tsv files (maybe even all files, and prompt user to select format if it's not .csv/.tsv)
+
+**Fixes:**
+- [x] fix: Vertical scrolling doesn't work in variable list rendering mode
+  - [ ] fix: Variable and Uniform lists have the separate scrolls. TODO: sync them
+  - [ ] fix: VariableList has no scroll bar, and scroll step is different from UniformList
+
+### Table: Minor UI Tweaks
+
+**Features:**
+- [ ] feat: Make uniform background + add horizontal lines between cells
+- [x] feat: Monospace font (with toggle)
+
+**Fixes:**
+
+### Row Identifiers (Line Numbers)
+
+**Features:**
+- [x] feat: Make width not resizable manually, but adjust to file size (number of lines)
+- [x] feat: Highlight number of selected (focused) line
+- [x] feat: Add numbering type: lines/rows
+
+**Fixes:**
+- [ ] fix: Calculate width of a character (currently hardcoded)
+- [x] fix: Update implementation to correspond to actual numbers in the source code (broken in multiline CSV rows)
+
+### Selection
+
+**Features:**
+- [x] feat: Update paddings (same for selected and not selected columns)
+- [x] feat: Add multiple selections using cmd modifier
+- [x] feat: Clear selection
+- [x] feat: Navigate with keyboard
+- [x] feat: Extend selection with keyboard
+- [x] feat: Optimize selection by using `SelectionStrategy`:
+  ```rust
+  enum SelectionStrategy {
+      /// Whole document (CMD+A)
+      AllCells,
+      /// Single cell or single range selected
+      SingleChunk(Chunk),
+      /// Multiple chunks selected while holding CMD
+      MultipleChunks(Vec<Chunk>)
+  }
+  enum Chunk {
+      /// Single cell
+      Cell(DisplayCellId),
+      /// Square range of cells
+      Range(DisplayCellId, DisplayCellId)
+  }
+  ```
+  - [ ] feat: Convert adjacent cells selected individually into a range if range is single dimention (1xN or Nx1)
+- [x] feat: Move viewport by keyboard selection
+- [x] feat: Move viewport by mouse selection
+
+**Fixes:**
+- [x] fix: Selection when sorted (follow data cells not display cells)
+
+### Copy Selected
+
+**Features:**
+- [x] feat: Add copying by Ctrl+C
+- [x] feat: Add copy as (CSV, TSV, markdown table, semicolon separated)
+- [x] feat: Copy in display mode (what you see) not data mode (how it's in file), or toggle between them
+
+**Fixes:**
+
+### Sorting by column
+
+**Features:**
+- [x] feat: Add tooltip on sort button
+- [ ] feat: Add manual ordering of columns by dragging (**needs infra**)
+
+**Fixes:**
+- [ ] fix: Focus/anchor cells are don't follow the ordered celection
+
+### Filtering
+
+**Features:**
+- [x] feat: Implement initial filtering by column
+  - [x] fix: Hide filtered out rows from filterables in adjacent columns (stacked filtering)
+    - [ ] fix: Sometimes stacked filtering implementation is too restrictive (especially with nulls). Investigate and fix
+  - [ ] feat: Update the filter popover to be persistent and with better ui
+- [ ] feat: Add search bar for filtering popover
+
+**Fixes:**
+
+### Editing
+
+**Features:**
+- [x] feat: Inline edits (click cell to enter editor mode. Edit text, hit enter, and changes applied to original file)
+  - [x] feat: Add virtual cell editing support (pad cells with delimiter, if row is less than number of columns for the table)
+  - [x] fix: Allow overflow for the editor. Style editor to have background, border and paddings
+    - [ ] fix: Add z-index, to be on top of adjacent cells
+    - [ ] fix: Overflow doesn't work correctly if it's set in any child div instead of parent div
+    ```rust
+    // Works correctly
+    div().overflow_hidden().child(div().child(some_child));
+    // Broken: on overflow, few pixels is still visible, is dynamic, depends on overall width of the cell
+    div().child(div().overflow_hidden().child(some_child));
+    ```
+- [ ] feat: Apply ordering settings (permanently write to buffer current rows and columns order)
+- [ ] feat: Paste from clipboard over several cells (parse based on defined separator). Allow only in `AllCells` / `SingleChunk` selection modes
+- [ ] feat: Add edit history with undo/redo
+
+**Fixes:**

crates/csv_preview/src/action_handlers.rs

@@ -0,0 +1,28 @@
+use gpui::ListAlignment;
+
+use crate::{CsvPreviewView, types::AnyColumn};
+
+mod copy_selected;
+mod selection_handlers;
+
+impl CsvPreviewView {
+    pub fn clear_filters(&mut self, col_idx: AnyColumn) {
+        self.engine.clear_filters_for_col(col_idx);
+        self.engine.apply_filtering();
+        self.list_state = gpui::ListState::new(
+            self.engine.d2d_mapping().visible_row_count(),
+            ListAlignment::Top,
+            ui::px(1.),
+        );
+    }
+
+    pub fn toggle_filter(&mut self, col_idx: AnyColumn, content_hash: u64) {
+        self.engine.toggle_filter(col_idx, content_hash);
+        self.engine.calculate_d2d_mapping();
+        self.list_state = gpui::ListState::new(
+            self.engine.d2d_mapping().visible_row_count(),
+            gpui::ListAlignment::Top,
+            ui::px(1.),
+        );
+    }
+}