Use livekit's Rust SDK instead of their swift SDK, take 2#20826
Closed
SomeoneToIgnore wants to merge 43 commits intomainfrom
Closed
Use livekit's Rust SDK instead of their swift SDK, take 2#20826SomeoneToIgnore wants to merge 43 commits intomainfrom
SomeoneToIgnore wants to merge 43 commits intomainfrom
Conversation
7e17646 to
b5b7ad2
Compare
b5b7ad2 to
0077602
Compare
2706b15 to
453112d
Compare
453112d to
22d10c2
Compare
814d5b5 to
5e192f7
Compare
a242c16 to
841262d
Compare
841262d to
8b6408f
Compare
ac57804 to
f980bda
Compare
5af8e26 to
73e343c
Compare
458ae9a to
454f380
Compare
1 task
a07c270 to
3861d07
Compare
1a0db76 to
39069ad
Compare
c0a0887 to
afa01a2
Compare
87018b2 to
afa01a2
Compare
mikayla-maki
added a commit
that referenced
this pull request
Dec 5, 2024
…#21550) Similar to #20826 but keeps the Swift implementation. There were quite a few changes in the `call` crate, and so that code now has two variants. Closes #13714 Release Notes: - Added preliminary Linux support for voice chat and viewing screenshares. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: Kirill Bulatov <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another take, applying #13343 and whatever fixes on top needed for it to be better
rtc::ToStringinstead ofstd::to_stringinSocketAddress::PortAsString()webrtc-sdk/webrtc#156Release Notes: