Revert "Use livekit's Rust SDK instead of their swift SDK (#13343)"#20809
Merged
SomeoneToIgnore merged 1 commit intomainfrom Nov 18, 2024
Merged
Revert "Use livekit's Rust SDK instead of their swift SDK (#13343)"#20809SomeoneToIgnore merged 1 commit intomainfrom
SomeoneToIgnore merged 1 commit intomainfrom
Conversation
Issues found: * audio does not work well with various set-ups using USB * switching audio during initial join may leave the client with no audio at all * audio streaming is done on the main thread, beachballing certain set-ups * worse screenshare quality (seems that there's no dynamic scaling anymore, compared to the Swift SDK) This reverts commit 1235d08.
cla-bot
bot
added
the
cla-signed
13 tasks
Contributor
|
Noooo, and just when I thought we would be able to package zed in nixpkgs properly 😭 |
Contributor
Author
|
I have a lot of |
SomeoneToIgnore
added a commit
that referenced
this pull request
Nov 18, 2024
13 tasks
SomeoneToIgnore
added a commit
that referenced
this pull request
Nov 19, 2024
SomeoneToIgnore
added a commit
that referenced
this pull request
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues found:
This reverts commit 1235d08.
Release Notes: