[MOB-1039] Retry broadcaster transactions with submit plans#1737

Closed

czarcas7ic wants to merge 14 commits into

mainfrom

adam/broadcaster-submit-plan

czarcas7ic commented May 12, 2026 •

edited

Loading

Contributor

Summary

Prevents the sync resubmission path from needing an ever-growing list of Broadcaster transactions to skip by recording the submit plan it should use for retry (cref [#1941] Add endpoint broadcaster API zcash-android-wallet-sdk#1937 (comment))
Adds pending submit plan storage for transactions created through Broadcaster.
Records the endpoints used by Broadcaster.submit and retries pending transactions with those endpoints instead of the synchronizer default endpoint.
Keeps legacy synchronizer submit paths on the existing SDK owned retry behavior.

Testing

swift test --filter OfflineTests
Targeted swiftlint lint on touched files, with only the existing SDKSynchronizer.swift:268 force unwrap warning reported.


          fix: retry broadcaster transactions with submit plans

0b1e1bb

czarcas7ic marked this pull request as ready for review

May 12, 2026 22:05

This was referenced May 12, 2026

[MOB-1039] Add multi-server transaction submission zodl-inc/zodl-ios#1751

Closed

[#1941] Add endpoint broadcaster API zcash/zcash-android-wallet-sdk#1937

Merged

czarcas7ic added 5 commits

May 12, 2026 16:38


          Cover raw submit plan endpoint registration

a73ceab


          Prune raw submit plan lookup entries

ca6d5d2


          Cover raw submit lookup path

4b3a786


          Validate pending submit plan version

c35d091


          fix: serialize broadcaster submit plan registration

7ec4edb

Chlup reviewed

View reviewed changes

Sources/ZcashLightClientKit/Transaction/PendingSubmitPlanStore.swift Outdated

Chlup reviewed

View reviewed changes

Sources/ZcashLightClientKit/Transaction/SubmitPlanExecutor.swift

Chlup reviewed

View reviewed changes

Sources/ZcashLightClientKit/Transaction/PendingSubmitPlanStore.swift Outdated

Chlup reviewed

View reviewed changes

Sources/ZcashLightClientKit/Transaction/PendingSubmitPlanStore.swift

Chlup reviewed

View reviewed changes

Sources/ZcashLightClientKit/Transaction/PendingSubmitPlanStore.swift Outdated

czarcas7ic added 2 commits

May 20, 2026 10:45


          fix: avoid submit plan overwrite after load failure

bd3a313


          fix: log submit plan endpoint failures

e749fec

czarcas7ic force-pushed the adam/broadcaster-submit-plan branch from fe63f0d to e749fec Compare

May 20, 2026 17:02

czarcas7ic added 4 commits

May 20, 2026 11:54


          Remove pending submit plan async lock

e236ddf


          Document pending submit plan store

fbd26ae


          Preserve raw submit endpoints during creation

02ff1de


          Merge upstream main into broadcaster submit plan

1c39fd1

thowar2 mentioned this pull request

Retry broadcaster transactions with submit plans just-zend/zcash-swift-wallet-sdk-zend#2

Merged

czarcas7ic added 2 commits

May 25, 2026 11:43


          fix: propagate raw transaction lookup errors

6cd9ae2


          fix: persist submit plans after load recovery

b9ba0c1

Chlup changed the title ~~Retry broadcaster transactions with submit plans~~ [MOB-1039] Retry broadcaster transactions with submit plans

linear Bot commented Jun 11, 2026

Chlup mentioned this pull request

[MOB-1039] Multi-server transaction submission with submit-plan retry #1757

Merged

Chlup marked this pull request as draft

June 16, 2026 06:22

Chlup commented Jun 16, 2026

Contributor

This was finally implemented in #1757

Chlup closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet