Skip to content

Retry broadcaster transactions with submit plans#2

Merged
octoclawd merged 21 commits into
mainfrom
adam/broadcaster-submit-plan
May 30, 2026
Merged

Retry broadcaster transactions with submit plans#2
octoclawd merged 21 commits into
mainfrom
adam/broadcaster-submit-plan

Conversation

@thowar2

@thowar2 thowar2 commented May 25, 2026

Copy link
Copy Markdown

Mirrors upstream PR: zcash#1737

Original author: @czarcas7ic


Summary

  • Prevents the sync resubmission path from needing an ever-growing list of Broadcaster transactions to skip by recording the submit plan it should use for retry (cref [#1941] Add endpoint broadcaster API zcash/zcash-android-wallet-sdk#1937 (comment))
  • Adds pending submit plan storage for transactions created through Broadcaster.
  • Records the endpoints used by Broadcaster.submit and retries pending transactions with those endpoints instead of the synchronizer default endpoint.
  • Keeps legacy synchronizer submit paths on the existing SDK owned retry behavior.

Testing

  • swift test --filter OfflineTests
  • Targeted swiftlint lint on touched files, with only the existing SDKSynchronizer.swift:268 force unwrap warning reported.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c39fd1f16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/ZcashLightClientKit/Synchronizer/SDKBroadcaster.swift Outdated
czarcas7ic and others added 9 commits May 25, 2026 11:43
Mainnet 3340000 → 3355000 (interval 2500).
Testnet 4010000 → 4030000 (interval 10000).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zcash-swift-wallet-sdk release version 2.6.0-alpha.3

# -----BEGIN PGP SIGNATURE-----
# Comment: GPGTools - https://gpgtools.org
#
# iQIzBAABCgAdFiEEM8uh69MjC3Gih0YlOANKuf2lcGcFAmoXRUgACgkQOANKuf2l
# cGeYLQ/8CkzwNb2td/zysMBUworLNUkl8YrBj0/AbOazpMb0v7QIOxw2ES0FuuX8
# 01R24OSi+VaHiy0bGHrW6+QlpXFlqUB/B2jk2NNR90e4Vr/DQJlzDVjMgnUkXgt4
# 67+sZ9ulm8dOWCLUO5KT91F4JGoQw7WqCPUbDpgp8PQ6n6/3M2TZvU6hBYDLOgVu
# RDQ7hAwF1IEJHMNGCekcFvD8mPyQKfsnFO3zpl876O2Tg2edGKX6kZqz4oEb2JH8
# 0TQOiXbPZyLvJ7Oi+Asg5HZ/87wYtXugxp7fI9aOclf0/4rlx3+V2UHEmxfFTm59
# nmKjqaNZw0kJPAOEkHTSB/mJeBirPBh3eZg6Xfw2tpNxyGqRFFhadp7vGMAVMLFC
# 6kVoMe48ngR/asmPrnzAlN36KCWY9rd09bCxBqO5FRIDeSqLvc9yNUtR1VeSyNWc
# 8GIzJhpZxBv3fTG5SzNyOVYFbRl6QIZ/AjkuEUoi/Avep7IU+7P1+/VNf1c1B3wa
# V0WoAEI6hBEU1eg/ziFWerh+d2wntv0ZU9ItCq0DFvNgIRRmi6PFRh9HxxdDN8qv
# qyI7RmPftf7NmJtF1SSsVcgYM148ycZgt8IsH13lp+7ge1XzV0AOp1Pn21TN49F8
# 3FKJdFwQFp76LUIVfgFGta0nK+u/wH9XeWV5cMK5dSW0ifKCKNM=
# =KJ+n
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed May 27 12:26:00 2026 PDT
# gpg:                using RSA key 33CBA1EBD3230B71A287462538034AB9FDA57067
# gpg: Can't check signature: No public key

# Conflicts:
#	CHANGELOG.md
#	Package.swift
#	rust/CHANGELOG.md
@octoclawd octoclawd merged commit 522e0d3 into main May 30, 2026
4 checks passed
@octoclawd octoclawd deleted the adam/broadcaster-submit-plan branch May 30, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants