Skip to content

[#1941] Add endpoint broadcaster API#1937

Merged
nullcopy merged 17 commits into
zcash:mainfrom
valargroup:adam/android-broadcaster
May 13, 2026
Merged

[#1941] Add endpoint broadcaster API#1937
nullcopy merged 17 commits into
zcash:mainfrom
valargroup:adam/android-broadcaster

Conversation

@czarcas7ic

@czarcas7ic czarcas7ic commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes: #1941
Resolves: MOB-1146

iOS counterparts: zcash/zcash-swift-wallet-sdk#1678 and zcash/zcash-swift-wallet-sdk#1737

Adds a public broadcaster API on Synchronizer that separates transaction creation from network submission. It can create/store proposed and PCZT transactions without broadcasting, submit created transactions to a caller-selected lightwalletd endpoint, and keeps the legacy submit APIs behavior-compatible by delegating through the broadcaster to the current endpoint.

Testing:

This tests the entire flow that includes PRs

Android.Auto.Manual.Multi-Server.Submit.mp4

@czarcas7ic czarcas7ic changed the title Add endpoint broadcaster API DRAFT: Add endpoint broadcaster API May 8, 2026
@greg0x greg0x mentioned this pull request May 8, 2026
Merged
This was referenced May 9, 2026
Closed
Closed
@czarcas7ic czarcas7ic changed the title DRAFT: Add endpoint broadcaster API Add endpoint broadcaster API May 9, 2026
@czarcas7ic czarcas7ic changed the title Add endpoint broadcaster API [#1941] Add endpoint broadcaster API May 9, 2026
@czarcas7ic czarcas7ic marked this pull request as ready for review May 9, 2026 03:41
@true-jared true-jared requested review from noop-sk and nullcopy May 11, 2026 18:30
nullcopy
nullcopy requested changes May 11, 2026
View reviewed changes

@nullcopy nullcopy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6b45f7c

Comment thread sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/transaction/SdkBroadcaster.kt
Comment thread sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/transaction/AutomaticResubmissionGuard.kt Outdated
Comment thread sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/transaction/SdkBroadcaster.kt Outdated
Comment thread sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/transaction/SdkBroadcaster.kt Outdated
Comment thread sdk-lib/src/main/java/cash/z/ecc/android/sdk/SdkSynchronizer.kt Outdated
Comment thread sdk-lib/src/test/java/cash/z/ecc/android/sdk/internal/transaction/SdkBroadcasterTest.kt Outdated
@true-jared true-jared requested review from nesence-m and removed request for noop-sk May 12, 2026 09:24
This was referenced May 12, 2026
Closed
Merged
@czarcas7ic czarcas7ic marked this pull request as draft May 12, 2026 19:22
@czarcas7ic czarcas7ic marked this pull request as ready for review May 12, 2026 21:36
@czarcas7ic czarcas7ic mentioned this pull request May 13, 2026
Open
nullcopy
nullcopy approved these changes May 13, 2026
View reviewed changes

@nullcopy nullcopy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 156fa4e

@nullcopy nullcopy merged commit cbb6f03 into zcash:main May 13, 2026
12 checks passed
This was referenced May 13, 2026
Closed
Merged
@thowar2 thowar2 mentioned this pull request May 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nullcopy nullcopy nullcopy approved these changes

@nesence-m nesence-m Awaiting requested review from nesence-m

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add endpoint broadcaster API for caller-managed transaction submission

2 participants

@czarcas7ic @nullcopy