ZIP-225/244 #2: Refactor transaction builder to create separate builders for each section.#386
Merged
nuttycom merged 17 commits intoJun 3, 2021
Conversation
therealyingtong
approved these changes
May 26, 2021
Contributor
therealyingtong
left a comment
therealyingtong
left a comment
There was a problem hiding this comment.
utACK commits 6adcb3f61f4e0146f274716f5b08942d4bf55496..0a662d6b2ec023903873f6688c7735984299aebb.
nuttycom
force-pushed
the
feature/zip-225-builder_modularization
branch
from
0a662d6 to
3997e59
Compare
nuttycom
changed the title
nuttycom
force-pushed
the
feature/zip-225-builder_modularization
branch
6 times, most recently
from
4d86a54 to
f16c610
Compare
nuttycom
force-pushed
the
feature/zip-225-builder_modularization
branch
2 times, most recently
from
d77b516 to
77f3133
Compare
nuttycom
force-pushed
the
feature/zip-225-builder_modularization
branch
from
d500e60 to
bd3b2af
Compare
Also, store the target height in the sapling builder.
str4d
reviewed
Jun 2, 2021
str4d
requested changes
Jun 2, 2021
Co-authored-by: str4d <jack@electriccoin.co>
Co-authored-by: str4d <jack@electriccoin.co>
nuttycom
force-pushed
the
feature/zip-225-builder_modularization
branch
from
ca30178 to
2b96e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends from #385 as refactoring prior to ZIP-225 implementation.