ZIP-225/244 #3: Create separate bundles for each part of the transaction.#392
Merged
Conversation
nuttycom
force-pushed
the
feature/zip-225-bundles
branch
2 times, most recently
from
160a6da to
1ead979
Compare
nuttycom
force-pushed
the
feature/zip-225-bundles
branch
6 times, most recently
from
7d7e1bf to
1274e4f
Compare
str4d
reviewed
Jun 3, 2021
nuttycom
force-pushed
the
feature/zip-225-bundles
branch
10 times, most recently
from
2b0a9ae to
7b7f1f4
Compare
str4d
requested changes
Jun 3, 2021
Contributor
There was a problem hiding this comment.
It would be nice if we could ensure that the arb_txins don't collide on their prevouts, but that's not technically necessary for structural validity checks.
This also adds parsing and serialization for Orchard bundle parts. This requires changes to the TZE builder components, because they refer to the TransactionData type in the context for witness creation.
nuttycom
force-pushed
the
feature/zip-225-bundles
branch
4 times, most recently
from
8f08d20 to
6c35c9b
Compare
nuttycom
force-pushed
the
feature/zip-225-bundles
branch
6 times, most recently
from
57529f7 to
b2a16d2
Compare
nuttycom
force-pushed
the
feature/zip-225-bundles
branch
from
b2a16d2 to
cc9dbf8
Compare
Co-authored-by: str4d <jack@electriccoin.co>
str4d
approved these changes
Jun 4, 2021
Contributor
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
utACK after the format! comments are addressed.
Co-authored-by: str4d <jack@electriccoin.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds atop #386
This takes inspiration from the Orchard design and creates a separate
Bundletype for each sub-protocol: transparent, Sprout, Sapling, and the future TZE transaction components.