ZIP-225/244 #1: Minor refactoring and preparatory updates.#385
Merged
Conversation
nuttycom
changed the title
nuttycom
changed the title
nuttycom
force-pushed
the
feature/zip-225-prep
branch
3 times, most recently
from
8bb252d to
0f3f5b0
Compare
str4d
reviewed
May 26, 2021
nuttycom
force-pushed
the
feature/zip-225-prep
branch
5 times, most recently
from
682a59d to
6715415
Compare
nuttycom
force-pushed
the
feature/zip-225-prep
branch
2 times, most recently
from
50ec4b3 to
62c454f
Compare
str4d
approved these changes
May 27, 2021
str4d
reviewed
May 27, 2021
Contributor
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
Just remembered that we should be documenting things in the changelogs 😅
str4d
approved these changes
May 27, 2021
Contributor
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
utACK. Changelog changes can be done in a subsequent PR.
Contributor
|
Needs a rebase now (because the changelog changes conflict). |
Contributor
|
Also |
Co-authored-by: str4d <jack@electriccoin.co>
nuttycom
force-pushed
the
feature/zip-225-prep
branch
from
475a1ef to
168314c
Compare
str4d
approved these changes
Jun 1, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of minor improvements to type safety factored out from #375.