Skip to content

pczt: Add public getters for spend_auth_sig and shielded_sighash#19

Closed
p0mvn wants to merge 1 commit into
maint/pczt-0.5.xfrom
roman/pczt-0.5.x/thv-pub-getters
Closed

pczt: Add public getters for spend_auth_sig and shielded_sighash#19
p0mvn wants to merge 1 commit into
maint/pczt-0.5.xfrom
roman/pczt-0.5.x/thv-pub-getters

Conversation

@p0mvn
Copy link
Copy Markdown

@p0mvn p0mvn commented Apr 10, 2026

Based on maint/pczt-0.5.x (branched from pczt-0.5.0 series). This is a
SemVer-compatible addition intended for a 0.5.x point release.

These getters enable downstream consumers to read the Orchard spend authorization signature from a PCZT after signing, and to access the cached shielded sighash from the Signer role for external verification.

Our Use

Enable Token Holder Voting by exposing:

  • PCZT getters — spend_auth_sig (read back HW wallet signature for ZK proof)
  • shielded_sighash (backport from main)

No new traits, no modifications to existing APIs.

See full summary of the integration: https://hackmd.io/@greg-nagy/voting-integration-architecture-changes-proposal

These getters enable downstream consumers to read the Orchard spend
authorization signature from a PCZT after signing, and to access the
cached shielded sighash from the Signer role for external verification.

Made-with: Cursor
@p0mvn p0mvn closed this Apr 10, 2026
greg0x pushed a commit that referenced this pull request Apr 14, 2026
…f0768ea4..dd0ea2c3c5

dd0ea2c3c5 Merge pull request #23 from zcash/2026-03-doc-fixes
93b26b7db1 v0.4.1 release - minor doc fixups
d528fa82e3 Merge pull request #22 from zcash/2025-12-doc-git-subtree
b421ef0b34 Merge pull request #22 from zcash/2025-12-doc-git-subtree
4a26e54c36 Fix git subtree command syntax in README
34bb38b606 Merge pull request #20 from zcash/doc/get_block
a507182f92 Document GetBlock transparent data behavior and clarify nullifier RPCs
fc5cc9a4b1 Merge pull request #19 from zcash/deprecate_get_nullifiers
f0ebc72cad Mark `GetBlockNullifiers` and `GetBlockRangeNullifiers` as deprecated.
9a5f7a0eec Merge pull request #16 from zcash/2026-01-remove-fullHeader
f1095897d9 revert the previous PR that added BlockID.fullHeader
99d9bf9fff Merge pull request #15 from zcash/2025-12-compactblock-doc
bbdd689d73 either CompactBlock.{hash, prevHash}, or CompactBlock.header
aa42926ed3 Merge pull request #13 from pacu/add-README
da4d3d57d8 Add rationale suggested by @LarryRuane
4edd22465b fix type
e36df314b8 clean up whitespace and line width
215cb5a3f3 Add PR suggestions. Organize Clients section
3e78d5d872 Apply suggestions from code review
96b86544db Apply suggestion from @LarryRuane
6259b97df0 Apply suggestion from @nuttycom
f2fcef3e42 Apply suggestion from @nuttycom
8cc1e66b11 Apply suggestion from @LarryRuane
99132222dd Apply suggestion from @nuttycom
207cc5e6f9 create a README file with context and instructions
7392b9706f Merge pull request #12 from zcash/release/v0.4.0

git-subtree-dir: zcash_client_backend/lightwallet-protocol
git-subtree-split: dd0ea2c3c5827a433e62c2f936b89efa2dec5a9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant