Merged
Conversation
This commit contains the following modifications: - Add tests for Lookup, ECC, Merkle, and Sinsemilla to verify that the verification key and the proof have not been modified by comparing them to those saved in a file. - Introduce a `LookupRangeCheck` trait that provides common methods for a lookup range check. - Use this new trait as a generic parameter in configs, chips and tests that are using lookup. - Create a new Lookup chip which is optimized for 4, 5 and 10-bit range check and add tests for this new chip. - Add `init_from_private_point` parameter in `SinsemillaConfig`. If this parameter is set to false, the `SinsemillaChip` is the same as the current `SinsemillaChip` used in vanilla circuit. Otherwise, the `SinsemillaChip` is modified to support hash from private point. --------- Co-authored-by: YaoGalteland <yao@qed-it.com> Co-authored-by: Dmitry Demin <dmitry@qed-it.com> Co-authored-by: Constance Beguier <constance@qed-it.com>
Fix clippy warnings
- Move lookup table `load` function into `LookupRangeCheck` trait (and remove `table_range_check_tag` function which is no longer used) - Move some imports to reduce the diff with the main branch - Standardize test circuit names with `My...Circuit` convention - Reduce visibility of some functions - Update changelog file
…okup table (#43) This PR adds a comment to clarify why a duplicated-rows range check lookup table was chosen.
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 28, 2025
daira
reviewed
Jul 29, 2025
daira
reviewed
Jul 29, 2025
Comment on lines
+116
to
+120
| /// If init_from_private_point is set, | ||
| /// | offset | x_A | x_P | q_sinsemilla4 | | ||
| /// -------------------------------------- | ||
| /// | 0 | | y_Q | | | ||
| /// | 1 | x_Q | | 1 | |
Contributor
There was a problem hiding this comment.
This should be documented in book/src/design/gadgets/sinsemilla.md. I have a commit for that and will push it later.
daira
reviewed
Jul 29, 2025
daira
reviewed
Jul 29, 2025
daira
reviewed
Jul 29, 2025
Contributor
There was a problem hiding this comment.
I have not checked any of these binary files, but they are only used for tests and I assume they correspond to the original proofs.
daira
reviewed
Jul 29, 2025
Contributor
There was a problem hiding this comment.
I have not checked any of these pinned verification keys.
daira
reviewed
Jul 29, 2025
daira
reviewed
Jul 29, 2025
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 67.96% 73.67% +5.70%
==========================================
Files 47 105 +58
Lines 5891 11951 +6060
==========================================
+ Hits 4004 8805 +4801
- Misses 1887 3146 +1259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following modifications that are required for ZSA:
LookupRangeCheckconfig namedLookupRangeCheck4_5BConfigoptimized for 4, 5 and 10-bit range checksmul_signCondSwapChipSinsemillaChipto support evaluating a hash from a private pointSinsemillaChipwith functions that allow separate evaluation of the hash and blinding factor of a commitmentMy...Circuitconvention