Merged
Conversation
Move some imports to reduce the diff with the main branch Standardize test circuit names Reduce visibility of some functions Update changelog file
ConstanceBeguier
force-pushed
the
clean_zsa_code
branch
from
50fb9ec to
71e68ab
Compare
ConstanceBeguier
force-pushed
the
clean_zsa_code
branch
from
71e68ab to
5737ffe
Compare
PaulLaux
reviewed
Jun 19, 2025
| /// Multiply the point by sign, using the q_mul_fixed_short gate. | ||
| /// Constraints `sign` in {-1, 1} | ||
| pub fn assign_scalar_sign( | ||
| pub(crate) fn assign_scalar_sign( |
Author
There was a problem hiding this comment.
To evaluate a variable-base sign-scalar multiplication in Orchard, we use the function mul_sign.
This function assign_scalarmulis used internally withinmul_sign` and is never called outside of Halo2.
PaulLaux
approved these changes
Jun 20, 2025
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Very nice.
Please add the naming change to the upstream PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.