Update for compatibility with latest halo2 version (ZSA features)#470
Merged
nuttycom merged 2 commits intozcash:mainfrom Aug 25, 2025
Merged
Update for compatibility with latest halo2 version (ZSA features)#470nuttycom merged 2 commits intozcash:mainfrom
nuttycom merged 2 commits intozcash:mainfrom
Conversation
daira
reviewed
Aug 11, 2025
|
|
||
| [patch.crates-io] | ||
| halo2_gadgets = { git = "https://github.com/zcash/halo2", rev = "2308caf68c48c02468b66cfc452dad54e355e32f" } | ||
| halo2_proofs = { git = "https://github.com/zcash/halo2", rev = "2308caf68c48c02468b66cfc452dad54e355e32f" } |
Contributor
There was a problem hiding this comment.
I checked that it is not necessary for halo2_poseidon to have a patch directive.
nuttycom
approved these changes
Aug 25, 2025
str4d
approved these changes
Aug 25, 2025
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Sep 8, 2025
Modifications in upstream from last merge - Merge pull request zcash#470 from QED-it/compatible_with_zsa_halo2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
orchardcrate to use thehalo2crate with ZSA features (link). It contains three key changes:LookupRangeChecktrait into scope (this maintains backward compatibility and allows existing code to function without additional modifications).allow_init_from_private_pointargument to theSinsemillaChipconfiguration.Cargo.tomlto point to the last version of thehalo2crate (with ZSA features).