Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no such module 'DOT' by pinning GraphViz 0.2.0 #1067

Merged
merged 3 commits into from
May 4, 2021

Conversation

yanamura
Copy link
Contributor

@yanamura yanamura commented May 3, 2021

Package.swift Outdated
@@ -19,7 +19,7 @@ let package = Package(
.package(url: "https://github.com/tuist/XcodeProj.git", from: "7.18.0"),
.package(url: "https://github.com/jakeheis/SwiftCLI.git", from: "6.0.0"),
.package(url: "https://github.com/mxcl/Version", from: "2.0.0"),
.package(url: "https://github.com/SwiftDocOrg/GraphViz.git", from: "0.4.0"),
.package(url: "https://github.com/SwiftDocOrg/GraphViz.git", from: "0.1.0"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the original issue in #1065, should this be pinned to 0.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinned version in Package.resolved is 0.2.0 , so both 0.1.0 and 0.2.0 are available.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think Package.resolved isn't used if the package is used as a dependency in another package, which is when the issue occurs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I got it! thanks for your suggestion. I'll fix now

@@ -2,9 +2,6 @@

## Next Version

#### Fixed
- Fixed no such mocule `DOT` error [#1065](https://github.com/yonaskolb/XcodeGen/pull/1065) @yanamura
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we pin the version below I believe this should still be fixed, so you an add it back with this PR, but fix mocule -> module

@yanamura yanamura changed the title Revert "Fix no such module 'DOT'" Fix no such module 'DOT' May 4, 2021
@yanamura yanamura changed the title Fix no such module 'DOT' Fix no such module 'DOT' by pinning GraphViz 0.2.0 May 4, 2021
@yanamura yanamura requested a review from yonaskolb May 4, 2021 15:03
@yonaskolb yonaskolb merged commit 1df0bb3 into yonaskolb:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants