Fix no such module 'DOT' by pinning GraphViz 0.2.0 #1067
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 69a1cd5.
yonaskolb
reviewed
May 3, 2021
Package.swift
Outdated
| @@ -19,7 +19,7 @@ let package = Package( | |||
| .package(url: "https://github.com/tuist/XcodeProj.git", from: "7.18.0"), | |||
| .package(url: "https://github.com/jakeheis/SwiftCLI.git", from: "6.0.0"), | |||
| .package(url: "https://github.com/mxcl/Version", from: "2.0.0"), | |||
| .package(url: "https://github.com/SwiftDocOrg/GraphViz.git", from: "0.4.0"), | |||
| .package(url: "https://github.com/SwiftDocOrg/GraphViz.git", from: "0.1.0"), | |||
There was a problem hiding this comment.
To fix the original issue in #1065, should this be pinned to 0.2?
There was a problem hiding this comment.
pinned version in Package.resolved is 0.2.0 , so both 0.1.0 and 0.2.0 are available.
There was a problem hiding this comment.
Yes, but I think Package.resolved isn't used if the package is used as a dependency in another package, which is when the issue occurs
There was a problem hiding this comment.
oh, I got it! thanks for your suggestion. I'll fix now
yonaskolb
reviewed
May 3, 2021
| @@ -2,9 +2,6 @@ | |||
|
|
|||
| ## Next Version | |||
|
|
|||
| #### Fixed | |||
| - Fixed no such mocule `DOT` error [#1065](https://github.com/yonaskolb/XcodeGen/pull/1065) @yanamura | |||
There was a problem hiding this comment.
If we pin the version below I believe this should still be fixed, so you an add it back with this PR, but fix mocule -> module
yanamura
changed the title
yonaskolb
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution