Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no such module 'DOT' #1065

Merged
merged 2 commits into from
May 2, 2021
Merged

Conversation

yanamura
Copy link
Contributor

@yanamura yanamura commented May 1, 2021

Problem

create cli folder and put this Package.swift

// swift-tools-version:5.1
import PackageDescription

let package = Package(
    name: "Tools",
    dependencies: [
        .package(url: "https://github.com/yonaskolb/XcodeGen", .branch("master"))
    ]
)

and run
swift run --package-path cli xcodegen

cause this error

XcodeGen/Sources/XcodeGenKit/GraphVizGenerator.swift:1:8: error: no such module 'DOT'
import DOT`

Solution

Update GraphViz 0.2.0 to 0.4.0
diff

With this update, we no longer to import Dot.

Changed package to produce a single library named `GraphViz` so that
  `Dot`, `Tools`, and `GraphVizBuilder` need not be imported separately anymore.

@freddi-kit
Copy link
Collaborator

Hi, @yanamura, thank you for your contribution! Could you update CHANGELOG.md about your fixing?

Example: https://github.com/yonaskolb/XcodeGen/pull/1064/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

please make Fixed column in Next Version.

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yanamura!

@yonaskolb yonaskolb merged commit 69a1cd5 into yonaskolb:master May 2, 2021
@yonaskolb
Copy link
Owner

It looks like CI didn't run for this PR for some reason. But now we have errors

ld: warning: Could not find or use auto-linked library 'cgraph'
ld: warning: Could not find or use auto-linked library 'gvc'
Undefined symbols for architecture x86_64:
  "_agerrors", referenced from:
      _$s8GraphViz7attempt8throwingxxyXE_tKlF in Error.swift.o
  "_aglasterr", referenced from:
      _$s8GraphViz5ErrorV04lastC7Message026_24C6592C881063ABBFDC7A6D4J5AA881LLSSSgvgZ in Error.swift.o
  "_agmemread", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_SpySo8Agraph_sVGSgSPys4Int8VGKXEfU_AWyXEfU_ in Renderer.swift.o
  "_gvContext", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_ in Renderer.swift.o
  "_gvFreeContext", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_6$deferL_yyF in Renderer.swift.o
  "_gvFreeLayout", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_6$deferL0_yyF in Renderer.swift.o
  "_gvFreeRenderData", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_6$deferL1_yyF in Renderer.swift.o
  "_gvLayout", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_ySPys4Int8VGKXEfU1_s5Int32VyXEfU_ in Renderer.swift.o
  "_gvRenderData", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_ySPys4Int8VGKXEfU2_s5Int32VyXEfU_ in Renderer.swift.o
  "_gvToolTred", referenced from:
      _$s8GraphViz8RendererC6render3dot2to2on10completionySS_AA6FormatOSo17OS_dispatch_queueCys6ResultOy10Foundation4DataVs5Error_pGctFyycfU_AQyKXEfU_s5Int32VyXEfU0_ in Renderer.swift.o
ld: symbol(s) not found for architecture x86_64
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)

yanamura added a commit to yanamura/XcodeGen that referenced this pull request May 3, 2021
yonaskolb pushed a commit that referenced this pull request May 4, 2021
* Revert "Fix no such module 'DOT' (#1065)"

This reverts commit 69a1cd5.

* pin GraphViz v0.2.0

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants