Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no such module 'DOT' by pinning GraphViz 0.2.0 #1067

Merged
merged 3 commits into from
May 4, 2021
Merged

Fix no such module 'DOT' by pinning GraphViz 0.2.0 #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85c001a
Revert "Fix no such module 'DOT' (#1065)"
yanamura May 3, 2021
7a4aa96
pin GraphViz v0.2.0
yanamura May 4, 2021
c0a8485
update CHANGELOG
yanamura May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Next Version

#### Fixed
- Fixed no such mocule `DOT` error [#1065](https://github.com/yonaskolb/XcodeGen/pull/1065) @yanamura
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we pin the version below I believe this should still be fixed, so you an add it back with this PR, but fix mocule -> module

- Fixed no such module `DOT` error [#1067](https://github.com/yonaskolb/XcodeGen/pull/1067) @yanamura

## 2.21.0

Expand Down
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"repositoryURL": "https://github.com/SwiftDocOrg/GraphViz.git",
"state": {
"branch": null,
"revision": "e9a73a30755c3c5b26ba7c73312b1f2ccb9a1a30",
"version": "0.4.0"
"revision": "70bebcf4597b9ce33e19816d6bbd4ba9b7bdf038",
"version": "0.2.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let package = Package(
.package(url: "https://github.com/tuist/XcodeProj.git", from: "7.18.0"),
.package(url: "https://github.com/jakeheis/SwiftCLI.git", from: "6.0.0"),
.package(url: "https://github.com/mxcl/Version", from: "2.0.0"),
.package(url: "https://github.com/SwiftDocOrg/GraphViz.git", from: "0.4.0"),
.package(url: "https://github.com/SwiftDocOrg/GraphViz.git", .exact("0.2.0")),
],
targets: [
.target(name: "XcodeGen", dependencies: [
Expand Down
1 change: 1 addition & 0 deletions Sources/XcodeGenKit/GraphVizGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import DOT
import Foundation
import GraphViz
import ProjectSpec
Expand Down