Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkldnn window build instructions in MKLDNN_README.md #2

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

yinghu5
Copy link
Owner

@yinghu5 yinghu5 commented May 14, 2019

Description

Updates mkldnn & MKL window cmake build instructions in MKLDNN_README.md, if the PR apache#14877 is merged

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

edisongustavo and others added 30 commits April 26, 2019 17:18
The PR apache#14570 has
introduced a bug where the "stash name" is not matching:

- It is **packed** as `ubuntu_cpu_int64`
- It is **unpacked** as `cpu_int64`
* [clojure][generator] add random namespace generation

* `ndarray_random_api`
* `symbol_random_api`

* fix tests
* Fix cached_op

* try to fix ci

* Fix CI

* Fix ci
* moved file

* Empty Commit

* Retrigger
* add fix in the code

* add unit test

* update comments
* Refactor requantize

* fix ci

* Fix CI

* Fix ci
* Enable zero-copy from numpy to MXNet NDArray

* should work

* make lint happy

* fix stupid typos

* wip to address comments

* Address comments

* Address comments

* Remove redundant code
…#14599)

* Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt

* Fix lint error with NULL vs nullptr
* Add unpooled gpu memory type

* Adding missing header

* undo bad rebase change
* Clojure BERT example: minor code cleanup

* Remove unused requires
* Remove unused vars & function
* Use `io` alias

* Clojure BERT example: whitespace fix

* Clojure BERT example: allow running with GPU

The `infer` function accepts a CPU/GPU context, which the command line
version of this example exposes as a `:cpu`/`:gpu`
keyword. Previously, these options were ignored and the context was
overridden to the default context (CPU). This commit allows
users (both REPL and shell) to pass in a GPU context.
* add quantized sum

* fix gpu compiler error and cpu testcase fail

* add default forward function for quantized_sum

* skip quantized_sum for gpu ctx

* fix comments

* fix indetation and comments

* retrigger CI

* alloc memeory through TmpMemMgr

*  fix comments Apr.12

* change sum to elemwise_add

* change Sum to ElemwiseAdd

* fix indents

* retrigger CI

* trigger CI

* fix indentation and typo

* trigger CI

* fix typo

* fix typo

* remove USE_MKLDNN macro for requantize params

* rename param same as its op

* trigger CI

* trigger CI

* trigger CI
* add resnet18 and mobilenetv2 models

* add readme

* support mkldnn s8s8 goihw16g weight format

* fix_readme_typo
* upgrade pylint to latest version & change the Makefile to use python3 pylint

* fix pylint when upgrade

* specify the pylint version

* suppress the pylint not-callable bug

* remove pylint from python2

* fix the typo

* upgrade cpp-package pylint

* move pylint disable to each block
* Updates Ubuntu GPU CI image base image to cuda10-devel and manually installs cuDNN version 7.3.1.20

* Updates CentOS 7 GPU CI image base image to cuda10-devel and manually installs cuDNN version 7.3.1.20
* remove unneeded test files

* add test files to gitignore
* Fix sample_multinomial number of outputs bug

* Fix lint
suyz526 and others added 17 commits May 5, 2019 09:51
* 	modified:   docs/api/python/gluon/contrib.md
	modified:   python/mxnet/gluon/contrib/__init__.py
	new file:   python/mxnet/gluon/contrib/cnn/__init__.py
	new file:   python/mxnet/gluon/contrib/cnn/conv_layers.py
	new file:   tests/python/gpu/test_gluon_contrib_gpu.py

* 	modified:   python/mxnet/gluon/contrib/cnn/conv_layers.py

* 	modified:   python/mxnet/gluon/contrib/cnn/conv_layers.py

* Update conv_layers.py

* Update conv_layers.py
* cpu optimized data loader

* Fix CI

* Fix CI

* Fix ci

* Fix doc
update MKL_ROOT
fix nomkldnn issue.
change MKL_ROOT
 powershell 'cd $Env:MKL_ROOT'
fix windows build instruction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.