This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Speed up SequenceReverse #14627
Merged
Speed up SequenceReverse #14627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributions @ptrendx. @mxnet-label-bot Add [Operator, pr-awaiting-review] |
ptrendx
force-pushed
the
pr_sequence_reverse
branch
from
b364a88
to
6192f90
Compare
|
@eric-haibin-lin Seems that there are still some problems with R and test_random on Windows. |
Closed
|
Thanks for updating the code. There were some flaky tests, could you sync with mxnet master? |
|
@eric-haibin-lin , could you review again, CI passed now. thanks! |
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the SequenceReverse operator use more parallelism in its execution, resulting in significant speedup.
I tested it on the GNMT en-vi example from GluonNLP (https://gluon-nlp.mxnet.io/model_zoo/machine_translation/index.html#google-neural-machine-translation) where it resulted in end to end speed increase from 33k wps to 44-45k wps on a single V100.
FYI @eric-haibin-lin @szha @fhieber @sbodenstein
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.