This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
added extraction/generation of diagonal/triangonal matrices to linalg #14501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmushetzel
force-pushed
the
diagtrian
branch
3 times, most recently
from
March 22, 2019 11:22
7d5e1db
to
b0fe5e4
Compare
@mseeger you may be interested in these operators |
All checks passed except two and the latter ones apparently related to a connectivity issue where they tried to download some data from a different server. Not sure that I can do anything about this. Any advice? |
@mxnet-label-bot add[pr-awaiting-review, Operator] |
@asmushetzel thanks for the contribution. Could you rebase the PR to the latest commit on master? |
rebased. |
Anything that I can help with to get this through? |
@asmushetzel Thanks for working on this. @eric-haibin-lin @reminisce @apeforest @anirudh2290 Can you please help review this PR? |
@eric-haibin-lin @reminisce @apeforest @anirudh2290 gentle ping for review. Thanks! |
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add operators to the linalg namespace to
This operators are useful for various tasks when working with linear algebra. We have a specific use case already where batches of triangular matrices exist and the non-zero entries above/below some diagonal must be rearranged as 1-d tensors.
There are various variants of such diagonal/triangular matrix manipulation in numpy (tril/triu/diag/diagonal/diagflat) and also one already in MXNet (diag-operator). Unfortunately without real consistency. MXNet's current diag operator is consistent with numpy's diag. So it lacks any notion of batches of matrices which is a fundamental concept for all linalg-operators.
It doesn't seem to be useful to write the "one fits all" operator for all types of manipulation of diagonal/triangular matrix operations. So this PR rather provides a consistent mechanism that can be used in the context of "linalg"-namespace and supports the usual operations that people need when they do advanced linear algebra. In particular, it does support the same level of batched matrix support, the same data types, diagonal and triangular matrices and enough flexibility to deal also with diagonal/triangular matrices that are defined by other than the main diagonal.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.