fix(weixin): allow Windows image paths inside workspace

[yiliang114]

Test PR - small (2 files, +63/-2)

[changeset-bot]

⚠️ No Changeset found

Latest commit: a2f3d07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
qwen-code	Error		May 26, 2026 1:16pm

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

[github-actions]

Qwen Code review did not complete successfully (it may have been superseded by a newer review request). See workflow logs.

[github-actions]

[Critical] realpathSync('/tmp/') in the ALLOWED_DIRS construction (line 143) throws ENOENT on Windows because /tmp/ does not exist on that platform. Since this PR explicitly adds Windows path support, validateImagePath — and therefore sendImage — is completely non-functional on the target platform. Every image send would throw before reaching the new isInsideAllowedDir logic.

Suggested fix — guard the POSIX-only entries:

const ALLOWED_DIRS: string[] = [
  tmpdir() + '/',
  ...(() => { try { return [realpathSync(tmpdir()) + '/']; } catch { return []; } })(),
  ...workspaceDirs.map((d) => realpathSync(resolve(d)) + '/'),
];
try { ALLOWED_DIRS.push('/tmp/', realpathSync('/tmp/') + '/'); } catch { /* Windows */ }

— qwen3.7-max via Qwen Code /review

[github-actions]

[Suggestion] The mock here uses p.includes('QwenCode\\002') to detect the workspace directory, but QwenCode\0022 (the sibling) contains QwenCode\002 as a substring. The test passes only because the hello.png branch fires first. A future refactor that reorders conditions or renames the test image could silently cause this security test to pass for the wrong reason.

Consider using exact path matching:

mockRealpathSync.mockImplementation((p: string) => {
  if (p === imagePath) return imagePath;
  if (p === workspaceDir) return workspaceDir;
  return p;
});

— qwen3.7-max via Qwen Code /review

[github-actions]

[Suggestion] Consider adding a test for cross-drive Windows paths (e.g., image on E:\Images\photo.png when the workspace is on D:\WorkGroup\...). This is a realistic Windows scenario — win32.relative across drives correctly returns an absolute path that gets rejected, but no test verifies this behavior.

— qwen3.7-max via Qwen Code /review