refactor(claude): Migrate agents to agent skills#995
Conversation
Replace Claude Code agents with the new agent skills format: - browser-extension-developer, lint-fixer, website-maintainer moved to .claude/skills/ - explorer moved to .claude/plugins/repomix-explorer/skills/ Agent skills use SKILL.md with YAML frontmatter (name + description) and provide a cleaner, validated structure for Claude Code integration.
- browser-extension-developer: Update structure to WXT framework, fix i18n keys (appDescription, openWithRepomix), correct commands - lint-fixer: Simplify workflow, add 4 tools (Biome, oxlint, tsgo, secretlint) with accurate config file references - website-maintainer: Add Editing Content section for document, sidebar, and shared settings locations Verified by sub-agents for accuracy and usability.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR migrates three agent documentation files from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @yamadashy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Claude Code agents by migrating them to a new, more organized agent skills format. The primary goal is to enhance the structure, validation, and overall clarity of these agent definitions, making them more efficient and easier to maintain. The changes involve moving agent configurations to a dedicated skills directory and refining their content for conciseness and accuracy. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying repomix with
|
| Latest commit: |
16eda3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a36b38fb.repomix.pages.dev |
| Branch Preview URL: | https://feat-agent-to-skill.repomix.pages.dev |
|
|
||
| ## i18n | ||
|
|
||
| 13 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi |
There was a problem hiding this comment.
Potential accuracy issue with language count: The skill mentions "13 languages" but the actual count appears to be 12 based on the directory listing. Consider verifying and updating:
| 13 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi | |
| 13 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi |
Should this be "12 languages" instead?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 110 110
Lines 7890 7890
Branches 1528 1528
=======================================
Hits 7131 7131
Misses 759 759 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the Claude agents to the new agent skills format. The new skill files are more concise, better structured, and provide more accurate information about the project, such as the WXT framework for the browser extension and the specific linting tools used. The changes align well with the goals stated in the description. I have one minor suggestion to correct a language count in the browser extension developer skill file.
|
|
||
| ## i18n | ||
|
|
||
| 13 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi |
There was a problem hiding this comment.
The text states there are 13 languages, but only 12 are listed. Please correct the count to match the list. The comment on line 15 should also be updated from '13 languages' to '12 languages' for consistency.
| 13 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi | |
| 12 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi |
|
|
||
| `npm run lint` runs 4 tools in sequence: | ||
|
|
||
| 1. **Biome** (`biome check --write`) - Formatter + linter, auto-fixes |
There was a problem hiding this comment.
Typo in tool name: "tsgo" should be "tsc" (TypeScript Compiler):
| 1. **Biome** (`biome check --write`) - Formatter + linter, auto-fixes | |
| 3. **tsc** (`tsc --noEmit`) - TypeScript type checking |
The TypeScript compiler command is tsc, not tsgo.
Code Review for PR #995: Migrate Claude Agents to Skills FormatThank you for this refactoring effort! The migration from agents to skills format represents a significant improvement in organization and maintainability. I've reviewed the changes and found the new structure to be cleaner and more concise. ✅ Strengths
🔍 Issues FoundI've left inline comments on specific lines for the following issues:
🎯 Premortem AnalysisPotential Failure ScenariosRisk 1: Skill Discovery Issues
Risk 2: Missing Context from Removed Content
Risk 3: Integration Breaking Changes
💡 SuggestionsAdditional Improvements
✅ RecommendationOnce the inline comments are addressed (language count and tsc typo), this PR is ready to merge. The migration improves code organization significantly and the new skills format is much more maintainable. Great work on the refactoring! 🚀 |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.claude/agents/browser-extension-developer.md(0 hunks).claude/agents/lint-fixer.md(0 hunks).claude/agents/website-maintainer.md(0 hunks).claude/skills/browser-extension-developer/SKILL.md(1 hunks).claude/skills/lint-fixer/SKILL.md(1 hunks).claude/skills/website-maintainer/SKILL.md(1 hunks)
💤 Files with no reviewable changes (3)
- .claude/agents/website-maintainer.md
- .claude/agents/lint-fixer.md
- .claude/agents/browser-extension-developer.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
.claude/skills/website-maintainer/SKILL.md
12-12: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
.claude/skills/browser-extension-developer/SKILL.md
12-12: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
- GitHub Check: Build and run (windows-latest, 25.x)
- GitHub Check: Build and run (macos-latest, 25.x)
- GitHub Check: Build and run (windows-latest, 24.x)
- GitHub Check: Build and run (windows-latest, 22.x)
- GitHub Check: Build and run (windows-latest, 20.x)
- GitHub Check: Build and run (ubuntu-latest, 25.x)
- GitHub Check: Build and run (ubuntu-latest, 22.x)
- GitHub Check: Build and run (ubuntu-latest, 24.x)
- GitHub Check: Build and run (ubuntu-latest, 20.x)
- GitHub Check: Test (ubuntu-latest, 24.x)
- GitHub Check: Test with Bun (windows-latest, latest)
- GitHub Check: Test (macos-latest, 22.x)
- GitHub Check: Test (windows-latest, 20.x)
- GitHub Check: Test (windows-latest, 25.x)
- GitHub Check: Build and run with Bun (windows-latest, latest)
- GitHub Check: claude-review
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
.claude/skills/lint-fixer/SKILL.md (1)
1-38: Well-structured skill documentation with clear workflow.The lint-fixer skill guide effectively documents the four-tool linting workflow, provides a practical step-by-step workflow, lists configuration files, and emphasizes behavioral constraints. The content is scoped, actionable, and consistent with skill documentation standards.
.claude/skills/browser-extension-developer/SKILL.md (1)
1-36: Well-documented skill with practical guidance for WXT framework development.The browser-extension-developer skill guide provides clear structure, covers key commands, documents i18n setup across 13 languages, and appropriately flags cross-browser compatibility considerations. Content is scoped and actionable.
- browser-extension-developer: Fix 13→12 languages (actual count) - Add 'plaintext' to fenced code blocks for markdownlint compliance
|
|
||
| ## i18n | ||
|
|
||
| 12 languages: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi |
There was a problem hiding this comment.
The language count is accurate - there are indeed 12 language directories. This appears correct based on the actual directory listing: en, ja, de, fr, es, pt_BR, id, vi, ko, zh_CN, zh_TW, hi
|
|
||
| 1. **Biome** (`biome check --write`) - Formatter + linter, auto-fixes | ||
| 2. **oxlint** (`oxlint --fix`) - Fast JS/TS linter, auto-fixes | ||
| 3. **tsgo** (`tsgo --noEmit`) - TypeScript type checking |
There was a problem hiding this comment.
The tool name "tsgo" is correct. Looking at the package.json, the command is indeed tsgo --noEmit (not tsc). "tsgo" appears to be a TypeScript runner/checker tool used by this project.
Code Review Update - PR #995After reviewing the existing feedback and examining the code changes in detail, I've added clarifications via inline comments addressing concerns raised by other reviewers: ✅ Clarifications Made
🎯 Additional ObservationsThe migration successfully achieves its goals:
✅ Overall AssessmentThis PR is well-executed and ready for merge. The new skill format is cleaner, more maintainable, and provides better integration with Claude's skill system. All technical details have been verified as accurate. The decision to exclude Great work on this refactoring! 🚀 |
Migrate Claude Code agents to the new agent skills format for better structure and validation.
Changes
Migration (agents → skills):
browser-extension-developer→.claude/skills/browser-extension-developer/SKILL.mdlint-fixer→.claude/skills/lint-fixer/SKILL.mdwebsite-maintainer→.claude/skills/website-maintainer/SKILL.mdImprovements:
Note:
repomix-explorerplugin agents remain unchanged as they are plugin-specific.Checklist
npm run testnpm run lint