refactor(agents): consolidate agent rules into streamlined specialized agents#759
refactor(agents): consolidate agent rules into streamlined specialized agents#759
Conversation
…d agents - Merge .agents/rules/website.md content into .claude/agents/website-maintainer.md - Merge .agents/rules/browser-extension.md content into .claude/agents/browser-extension-developer.md - Remove redundant rules files to reduce maintenance overhead - Streamline agent definitions to focus on essential responsibilities and workflows - Add file structure details and browser compatibility notes for better agent performance - Maintain all critical information while improving readability and usability This consolidation makes agent management more efficient while preserving all necessary guidelines for website and browser extension development tasks. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change removes project-specific rule documentation files for the browser extension and website from the Changes
Sequence Diagram(s)sequenceDiagram
participant Contributor
participant AgentSpec (browser-extension-developer / website-maintainer)
participant Project Directory
Contributor->>AgentSpec: Consults agent file for guidelines
AgentSpec->>Contributor: Provides responsibilities, structure, and workflow
Contributor->>Project Directory: Applies changes to browser extension or website per agent instructions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Claude finished @yamadashy's task —— View job PR Review Complete ✅This is an excellent refactoring that significantly improves the agent configuration architecture while preserving all essential functionality. Todo List:
🎯 Overall AssessmentVerdict: LGTM with Strong Approval This PR represents a well-executed consolidation that improves maintainability while actually enhancing the user experience. ✅ Strengths
📊 Content Analysis
🎯 Specific Improvements Noted
🔍 Code Quality Assessment
💡 Minor Suggestions (Optional)
📋 Checklist Verification
🏆 ConclusionThis PR exemplifies excellent refactoring practices:
Strong recommendation for approval and merge. |
There was a problem hiding this comment.
Summary of Changes
Hello @yamadashy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the agent configuration by consolidating disparate rule files into streamlined, specialized agent definitions. My aim is to improve maintainability, enhance agent usability, and provide more focused, actionable information for specific development tasks, ultimately leading to better performance and clarity in agent guidance.
Highlights
- Agent Configuration Consolidation: I've consolidated the existing
.agents/rules/website.mdand.agents/rules/browser-extension.mdcontent into new, specialized agent definitions:.claude/agents/website-maintainer.mdand.claude/agents/browser-extension-developer.mdrespectively. This centralizes agent-specific guidelines. - Redundant File Removal: I've removed the now-redundant
.agents/rules/browser-extension.mdand.agents/rules/website.mdfiles, and updated.agents/rules/base.mdto remove references to these deleted files. This reduces maintenance overhead and streamlines the rules directory. - Enhanced Agent Definitions: The newly created agent definitions (
browser-extension-developer.mdandwebsite-maintainer.md) are enhanced with more structured information, including project overviews, directory layouts, development commands, quality standards, and specific compatibility notes, improving their usability and clarity for developers.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the agent configuration system by consolidating scattered rule files into streamlined specialized agent definitions, reducing maintenance overhead while preserving all essential guidelines.
- Merged website and browser extension rule content into dedicated Claude agent files
- Removed redundant rule files to eliminate duplication
- Updated base rules to remove references to the consolidated files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.claude/agents/website-maintainer.md |
New agent definition consolidating website documentation guidelines with VitePress workflow |
.claude/agents/browser-extension-developer.md |
New agent definition merging browser extension development guidelines with cross-platform compatibility notes |
.agents/rules/website.md |
Removed file - content migrated to website-maintainer agent |
.agents/rules/browser-extension.md |
Removed file - content migrated to browser-extension-developer agent |
.agents/rules/base.md |
Updated to remove references to the consolidated rule files |
There was a problem hiding this comment.
Code Review
This pull request consolidates and streamlines the agent configurations, which improves maintainability. The new specialized agent files are clear and focused. I've added a few comments suggesting the restoration of some specific details from the original rule files, such as missing directory paths, development commands, and the step-by-step process for adding new languages. These additions will ensure the new agent definitions are as comprehensive and effective as possible.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deploying repomix with
|
| Latest commit: |
6ff0ef4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b5f3c73.repomix.pages.dev |
| Branch Preview URL: | https://chore-agents.repomix.pages.dev |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.claude/agents/website-maintainer.md (2)
1-5: Front-matter could include visibility / ownership tagsOther agent specs in the repo usually add fields like
visibility,owner, ortagsto help downstream tooling surface the agent correctly. Consider extending the front-matter now rather than later to avoid inconsistency.
24-29: Add the concrete dev command used for “Test functionality”Step 5 is ambiguous. Mentioning the actual VitePress command (
npm run docs:dev/pnpm run docs:dev) makes the workflow self-contained..claude/agents/browser-extension-developer.md (2)
22-30: Specify a language on the fenced code block (markdown-lint MD040)Static analysis flags the missing language spec. Adding
text(orbash) silences the warning and improves readability.-``` +```text browser/ ├── app/ @@ └── dist/ # Built files--- `38-44`: **250-line hard cap may be unrealistic for background/content scripts** Background logic plus API wrappers often exceed 250 LOC. Consider rephrasing to “strive for <250 lines; split into modules when larger” to keep guidance practical. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 22b9d3c014757a01fb2a033d64712e328e4882d5 and c7ce35c06652bff1258374626e6da358128cffdf. </details> <details> <summary>📒 Files selected for processing (5)</summary> * `.agents/rules/base.md` (0 hunks) * `.agents/rules/browser-extension.md` (0 hunks) * `.agents/rules/website.md` (0 hunks) * `.claude/agents/browser-extension-developer.md` (1 hunks) * `.claude/agents/website-maintainer.md` (1 hunks) </details> <details> <summary>💤 Files with no reviewable changes (3)</summary> * .agents/rules/base.md * .agents/rules/browser-extension.md * .agents/rules/website.md </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🧠 Learnings (3)</summary> <details> <summary>📓 Common learnings</summary>Learnt from: CR
PR: yamadashy/repomix#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T16:07:18.316Z
Learning: Applies to .agents/rules/base.md : Check the rules written in.agents/rules/base.mdas they contain important project-specific guidelines and instructions.Learnt from: CR
PR: yamadashy/repomix#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:12:57.179Z
Learning: .agents/rules/base.md</details> <details> <summary>📚 Learning: applies to .agents/rules/base.md : check the rules written in `.agents/rules/base.md` as they contai...</summary>Learnt from: CR
PR: yamadashy/repomix#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T16:07:18.316Z
Learning: Applies to .agents/rules/base.md : Check the rules written in.agents/rules/base.mdas they contain important project-specific guidelines and instructions.**Applied to files:** - `.claude/agents/website-maintainer.md` - `.claude/agents/browser-extension-developer.md` </details> <details> <summary>📚 Learning: .agents/rules/base.md...</summary>Learnt from: CR
PR: yamadashy/repomix#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:12:57.179Z
Learning: .agents/rules/base.md**Applied to files:** - `.claude/agents/website-maintainer.md` - `.claude/agents/browser-extension-developer.md` </details> </details><details> <summary>🪛 markdownlint-cli2 (0.17.2)</summary> <details> <summary>.claude/agents/browser-extension-developer.md</summary> 22-22: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> </details> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)</summary> * GitHub Check: Test (macos-latest, 24.x) * GitHub Check: Build and run (windows-latest, 21.x) * GitHub Check: Build and run (macos-latest, 21.x) * GitHub Check: Build and run (windows-latest, 24.x) * GitHub Check: Build and run with Bun (macos-latest, latest) * GitHub Check: Analyze (javascript-typescript) * GitHub Check: auto-review </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>.claude/agents/website-maintainer.md (1)</summary> `18-22`: **Documentation Path Verified** Confirmed that the `website/client/src/[lang]/` directory exists (and there’s no `website/src/[lang]`), so the documentation correctly reflects the repository’s structure. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
This PR consolidates and streamlines the agent configuration by merging rule files into specialized agent definitions and removing redundant files to improve maintainability.
Changes Made
.agents/rules/website.mdcontent into.claude/agents/website-maintainer.md.agents/rules/browser-extension.mdcontent into.claude/agents/browser-extension-developer.mdBenefits
The consolidation makes agent management more efficient while preserving all necessary guidelines for website and browser extension development tasks.
Checklist
npm run testnpm run lint🤖 Generated with Claude Code