Skip to content

refactor(claude): Consolidate lint-fixer skill and move skills to subdirectories#1110

Merged
yamadashy merged 2 commits intomainfrom
refactor/consolidate-lint-fix-command
Jan 23, 2026
Merged

refactor(claude): Consolidate lint-fixer skill and move skills to subdirectories#1110
yamadashy merged 2 commits intomainfrom
refactor/consolidate-lint-fix-command

Conversation

@yamadashy
Copy link
Owner

@yamadashy yamadashy commented Jan 23, 2026

Reorganize Claude skills for better maintainability.

Summary

  • Remove redundant lint-fixer skill and integrate its info into code:lint-fix command
  • Move browser-extension-developer skill to browser/.claude/skills/
  • Move website-maintainer skill to website/.claude/skills/

Checklist

  • Run npm run test
  • Run npm run lint

Open with Devin

Remove redundant lint-fixer skill and integrate its essential information
directly into the code:lint-fix command. This reduces duplication as the
skill was simply a wrapper providing the same information.

- Update .agents/commands/code/lint-fix.md with lint tool details
- Remove .claude/skills/lint-fixer/SKILL.md
Move browser and website specific skills to their respective directories
for better organization and locality.

- Move browser-extension-developer skill to browser/.claude/skills/
- Move website-maintainer skill to website/.claude/skills/
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yamadashy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the maintainability and organization of Claude's skills. It streamlines the lint-fixer functionality by embedding its details directly into the code:lint-fix command documentation, eliminating a redundant skill file. Additionally, it improves the directory structure by relocating domain-specific skills, such as browser-extension-developer and website-maintainer, into dedicated subdirectories. These changes aim to make the skill set more coherent and easier to manage.

Highlights

  • Skill Consolidation: The dedicated lint-fixer skill has been removed, and its essential information, including details on lint tools and configuration files, has been integrated directly into the .agents/commands/code/lint-fix.md documentation.
  • Skill Relocation: The browser-extension-developer skill has been moved to browser/.claude/skills/ and the website-maintainer skill to website/.claude/skills/, organizing them into domain-specific subdirectories for better structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The PR consolidates lint-fixer documentation by reorganizing content from a deleted skill documentation file into a streamlined agent command file, moving workflow guidance into a compact command reference format with tool and configuration listings.

Changes

Cohort / File(s) Summary
Lint-fixer Documentation Reorganization
​.agents/commands/code/lint-fix.md, ​.claude/skills/lint-fixer/SKILL.md
Modified lint-fix.md to replace verbose instructions with a concise directive, adding a "Lint Tools (in order)" section with four tools and a "Config Files" section. Deleted SKILL.md which contained detailed workflow steps, tool descriptions, and configuration guidelines.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: consolidating the lint-fixer skill and moving skills to subdirectories, which aligns with the file modifications.
Description check ✅ Passed The description covers the main changes with clear bullet points and includes the required checklist items, though it could provide more detail about the consolidation rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/consolidate-lint-fix-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good refactoring that improves the organization of the Claude skills by moving them into relevant subdirectories and consolidating the lint-fixer skill. My review includes one suggestion for the code:lint-fix command to retain important workflow steps from the old skill definition, particularly the need to run tests after fixing lint issues to prevent regressions. Otherwise, the changes look good.

@cloudflare-workers-and-pages
Copy link

Deploying repomix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6390e9c
Status: ✅  Deploy successful!
Preview URL: https://684d8bd6.repomix.pages.dev
Branch Preview URL: https://refactor-consolidate-lint-fi.repomix.pages.dev

View logs

@claude
Copy link
Contributor

claude bot commented Jan 23, 2026

Code Review Summary

✅ Overall Assessment: LGTM

This is a clean refactoring PR that improves skill organization and reduces duplication. The changes are minimal, focused, and low-risk.

Changes Reviewed

  1. Consolidated lint-fixer skill into lint-fix command - Removed 38 lines of redundant skill documentation and integrated essential information (lint tools and config files) into the command file.

  2. Relocated domain-specific skills - Moved browser-extension-developer to browser/.claude/skills/ and website-maintainer to website/.claude/skills/.

Positive Aspects

  • Reduced duplication: The lint-fixer skill was essentially a wrapper around the command. Consolidation makes sense.
  • Better locality: Moving skills to their respective directories (browser/, website/) follows the principle of co-locating related code.
  • Clean diff: File renames preserve content integrity.
Minor Observations
  • The new lint-fix.md is more concise (10 lines vs 38 lines), which is appropriate for a command prompt. It retains the critical information: tool execution order, auto-fix capabilities, and config file locations.

  • The workflow guidance from the original skill (run lint → fix → verify → test) was omitted. This is acceptable since it's implied by the command context, but could be added back as a single line if desired.

Premortem Analysis

Scenario Risk Mitigation
Skills not discovered in subdirectories Low Claude Code discovers skills recursively. Both browser/.claude/skills/ and website/.claude/skills/ are valid locations. ✅
Breaking references to old skill paths Low Grep search confirms no stale references to lint-fixer, and the moved skills retain their original names. ✅
CI/test impact None The PR only affects markdown documentation files used by Claude. No code changes that could affect tests. ✅

Checklist Verification

  • npm run test - Marked as complete in PR
  • npm run lint - Marked as complete in PR
  • ✅ Commit messages follow Conventional Commits format
  • ✅ No security concerns (documentation-only changes)

🤖 Review by Claude

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.17%. Comparing base (97c5845) to head (6390e9c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         116      116           
  Lines        4382     4382           
  Branches     1019     1019           
=======================================
  Hits         3820     3820           
  Misses        562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yamadashy
Copy link
Owner Author

Thanks for the review!

Regarding the workflow information - this is intentionally kept minimal because:

  • CLAUDE.md already instructs to run npm run test after completing implementation
  • The lint-fix command should focus on lint-specific details, not general workflow

Keeping the command documentation concise avoids duplication with project-level guidelines.

@yamadashy yamadashy merged commit bec88a3 into main Jan 23, 2026
59 checks passed
@yamadashy yamadashy deleted the refactor/consolidate-lint-fix-command branch January 23, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant