Skip to content

Conversation

@iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented Mar 11, 2021

This PR.

  • Eliminates a few list allocations (and possible internal resizes) by using arrays
  • Eliminates a queue allocation
  • Ensures string comparisons are invariant
  • Eliminates a possible NRE when allocating ReferralLinksExtension with a null value and subsequently adding additional rels

@MihaZupan
Copy link
Collaborator

There's some overlap with #527 on the Rel changes.

I don't think we'd want to bump the target just for this. We did already but reverted that, see #466.

@iamcarbon
Copy link
Contributor Author

iamcarbon commented Mar 11, 2021

@MihaZupan -- It looks like you won the race to fix these nullable violations.

Let's get your change committed first and I'll rebase and start a new PR with a clean history.

@iamcarbon iamcarbon closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants