-
-
Notifications
You must be signed in to change notification settings - Fork 496
Bring back net45 target #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2840c72 to
db867de
Compare
Slightly different from the previous implementation in order to mimic `System.Array.Empty<T>()` closely.
d9d4f75 to
16c0b6a
Compare
Latest Markdig supports netstandard 2.0 which is compatible with .NET 4.7.1+ so saying that traditional WPF applications can't work anymore is not correct. |
|
For net40, that will be a no go. A small OSS project like Markdig can't afford to have to maintain old FWK like net40. |
|
I'm not talking about bringing back net40 (that is end of life anyway) but net45 is still supported until 2023. The main issue regarding 4.5 is that it is the default runtime installed on Windows 8.1. Default version on Windows 10 is also 4.6 so a huge portion of the market won't be able to use my library. |
That's ok, the changes are minimal. But we will remove support for it at this date. |
|
Quite unfortunate/ironic that Visual Studio is the one stuck on an ancient framework :/ |
According to Visual Studio 2019 System Requirements, it is the setup that is required to run on the stock version installed by default on the system. It does install .NET 4.7.2 as a part of the installation (same for VS 2017). |
I am the author of Markdig.Wpf and recently support for .NET framework was dropped in Markdig (#416). That is a huge breaking change for me since it means my library cannot be used anymore in traditional WPF appplication (i.e. not using netcore3.1 or later).
I propose to bring back at least net45 support since it doesn't need to many changes (only
Array.Empty<T>need special care as of now).I was also supporting net40 but it seems that it is already a done deal here. It was requested by the Visual Studio setup team since they are using my library (Kryptos-FR/markdig.wpf#25). I have opened a discussion on my own repo to decide what to do for that net40 support (Kryptos-FR/markdig.wpf#41).
Note:
net452is part of Windows 8.1 and will be supported until at least January 2023 (see https://support.microsoft.com/en-sg/lifecycle/search?alpha=Windows%208.1 and https://docs.microsoft.com/en-sg/lifecycle/faq/dotnet-framework#what-is-the-lifecycle-policy-for-different-versions-of-the-net-framework).