A few nullable changes #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
commented
Mar 11, 2021
|
|
||
| Assert.That(html, !Contains.Substring("rel=")); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I don't know if I'm missing something, but I don't understand this test.
If you don't want the rel being output... don't add the extension?
MihaZupan
commented
Mar 11, 2021
| { | ||
| Rel = NoFollow; | ||
| } | ||
| else if (!Rel!.Contains(NoFollow)) |
Collaborator
Author
There was a problem hiding this comment.
This ! isn't needed on Core 3.1+, sadly older runtimes aren't smart enough to realize string.IsNullOrEmpty is a null check
Contributor
There was a problem hiding this comment.
This logic needs reworked to correctly handle null.
Collaborator
Author
There was a problem hiding this comment.
It does handle it via string.IsNullOrEmpty
Contributor
There was a problem hiding this comment.
Indeed. Missed the outer logic changes here. 👍
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @iamcarbon