Skip to content

fix: fixes for interfaces, unions, and required types#541

Merged
devsergiy merged 7 commits intomasterfrom
david/eng-2396-fix-interfaces-and-unions
Jun 21, 2023
Merged

fix: fixes for interfaces, unions, and required types#541
devsergiy merged 7 commits intomasterfrom
david/eng-2396-fix-interfaces-and-unions

Conversation

@Aenimus
Copy link
Copy Markdown
Member

@Aenimus Aenimus commented Jun 12, 2023

This PR aims to fix the following:

  1. In certain circumstances, required fields that were queried were being skipped instead of being resolved
  2. Interfaces and unions were not working properly in multiple instances

Comment thread go.mod
Comment thread pkg/engine/datasource/graphql_datasource/graphql_datasource.go
Comment thread pkg/engine/plan/plan.go Outdated
Comment thread pkg/engine/plan/plan.go
Comment thread pkg/engine/plan/plan.go Outdated
Comment thread pkg/engine/plan/plan.go Outdated
Comment thread pkg/testing/federationtesting/federation_integration_test.go
Comment thread pkg/engine/plan/plan.go Outdated
Comment thread pkg/engine/plan/plan.go Outdated
Comment thread pkg/engine/plan/plan.go Outdated
Comment thread pkg/engine/plan/plan.go
Comment thread pkg/engine/plan/plan.go
@devsergiy devsergiy merged commit 6fbbb7d into master Jun 21, 2023
@devsergiy devsergiy deleted the david/eng-2396-fix-interfaces-and-unions branch June 21, 2023 10:17
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 23, 2023
This PR aims to fix the following:
1. In certain circumstances, required fields that were queried were
being skipped instead of being resolved
2. Interfaces and unions were not working properly in multiple instances

---------

Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 26, 2023
This PR adds the following changes from wundergraph:
- wundergraph#534
- wundergraph#538
- wundergraph#540
- wundergraph#543
- wundergraph#541

---------

Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 28, 2023
This PR adds the following changes from wundergraph:
- wundergraph#534
- wundergraph#538
- wundergraph#540
- wundergraph#543
- wundergraph#541

---------

Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants