Skip to content

fix: provide more accurate error for invalid fragment spread#538

Merged
Aenimus merged 5 commits intomasterfrom
david/eng-2487-return-more-accurate-invalid-fragment-spread-error
Jun 6, 2023
Merged

fix: provide more accurate error for invalid fragment spread#538
Aenimus merged 5 commits intomasterfrom
david/eng-2487-return-more-accurate-invalid-fragment-spread-error

Conversation

@Aenimus
Copy link
Copy Markdown
Member

@Aenimus Aenimus commented Jun 5, 2023

Spreading a fragment on an invalid type should provide a more accurate error.

Also revert an accidental change of port for the federation example.

Copy link
Copy Markdown
Member

@devsergiy devsergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

@Aenimus Aenimus requested a review from devsergiy June 5, 2023 18:08
Comment thread pkg/astvalidation/operation_rule_fragments.go Outdated
@Aenimus Aenimus requested a review from fiam June 6, 2023 00:14
Copy link
Copy Markdown
Contributor

@fiam fiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aenimus Aenimus merged commit 2e219a6 into master Jun 6, 2023
@devsergiy devsergiy deleted the david/eng-2487-return-more-accurate-invalid-fragment-spread-error branch June 6, 2023 12:11
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 23, 2023
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 26, 2023
This PR adds the following changes from wundergraph:
- wundergraph#534
- wundergraph#538
- wundergraph#540
- wundergraph#543
- wundergraph#541

---------

Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request Jun 28, 2023
This PR adds the following changes from wundergraph:
- wundergraph#534
- wundergraph#538
- wundergraph#540
- wundergraph#543
- wundergraph#541

---------

Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com>
Co-authored-by: David Stutt <david@wundergraph.com>
Co-authored-by: spetrunin <neyasut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants