Merged
Conversation
Registration is not goroutine-safe, run a dummy validation once to force the registration, avoiding the race condition in subsequent parallel runs.
devsergiy
approved these changes
May 15, 2023
devsergiy
requested changes
May 15, 2023
Member
devsergiy
left a comment
devsergiy
left a comment
There was a problem hiding this comment.
tests are failing with this change
Contributor
Author
Yep, on it |
jensneuse
approved these changes
May 16, 2023
…hema/v5 github.com/qri-io/jsonschema has race conditions, bugs and seems to not be maintained anymore.
fiam
changed the title
jensneuse
approved these changes
May 16, 2023
devsergiy
reviewed
May 16, 2023
devsergiy
approved these changes
May 16, 2023
pvormste
added a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Jun 23, 2023
pvormste
added a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Jun 26, 2023
This PR adds the following changes from wundergraph: - wundergraph#534 - wundergraph#538 - wundergraph#540 - wundergraph#543 - wundergraph#541 --------- Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com> Co-authored-by: David Stutt <david@wundergraph.com> Co-authored-by: spetrunin <neyasut@gmail.com>
pvormste
added a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Jun 28, 2023
This PR adds the following changes from wundergraph: - wundergraph#534 - wundergraph#538 - wundergraph#540 - wundergraph#543 - wundergraph#541 --------- Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com> Co-authored-by: David Stutt <david@wundergraph.com> Co-authored-by: spetrunin <neyasut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/qri-io/jsonschema has race conditions, bugs and seems to not
be maintained anymore. Use github.com/santhosh-tekuri/jsonschema/v5 instead