Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
===========================================
- Coverage 63.29% 38.19% -25.11%
===========================================
Files 244 778 +534
Lines 25757 116297 +90540
Branches 0 8176 +8176
===========================================
+ Hits 16303 44417 +28114
- Misses 8087 71518 +63431
+ Partials 1367 362 -1005 🚀 New features to boost your workflow:
|
Aenimus
left a comment
There was a problem hiding this comment.
We're going do this in a more incremental and manageable way. Discussing elsewhere.
e55360c to
9f18c0b
Compare
WalkthroughCI workflows and linting configuration updated: added lint step to controlplane CI workflow, modified studio CI workflow to comment out active lint step, extended Prettier ignore patterns to exclude testdata directories, and updated controlplane emails build script to remove inline linting while extending ESLint to include .tsx files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/controlplane-ci.yaml:
- Around line 69-70: The CI step "Lint & format" currently runs "pnpm run
--filter ./controlplane/ lint:fix" which skips the controlplane/emails package;
update the workflow run command to include the emails workspace so its .tsx
linting runs too, e.g. add a second filter for "controlplane/emails" (use
multiple --filter flags) or run the workspace-wide script (pnpm -w run lint:fix)
so both controlplane and controlplane/emails lint:fix are executed; change the
run line accordingly in the "Lint & format" job.
In @.github/workflows/studio-ci.yaml:
- Around line 46-47: Re-enable the Studio lint step in the CI workflow by
restoring the commented job that runs "pnpm run --filter studio lint:fix" (or
switch to "pnpm run --filter studio lint" if you want a non-mutating check) so
that the studio package is explicitly linted/formatted before the
"git-dirty-check" gate; locate the commented block with the step name "Lint" and
update it to run the chosen command (lint or lint:fix) and ensure it appears
before the "git-dirty-check" step.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c2c5768e-6b48-44eb-aefb-3271912bc366
📒 Files selected for processing (5)
.github/workflows/controlplane-ci.yaml.github/workflows/studio-ci.yaml.prettierignorecontrolplane/emails/package.jsonshared/.prettierignore
Summary by CodeRabbit
Release Notes
Checklist
Fixes formatting drift in the monorepo. Enforces formatting for studio package and fixes indirection in controlplane