Skip to content

fix: configurations for prettier#2599

Merged
comatory merged 3 commits intomainfrom
ondrej/eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci
Mar 6, 2026
Merged

fix: configurations for prettier#2599
comatory merged 3 commits intomainfrom
ondrej/eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci

Conversation

@comatory
Copy link
Copy Markdown
Contributor

@comatory comatory commented Mar 6, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated CI pipeline configuration and linting workflows to improve code quality processes.
    • Enhanced build script configuration and code formatting rules across the project.
    • Expanded code linting to cover additional file types.
    • Adjusted ignore patterns for code formatting and test data directories.

Checklist

Fixes formatting drift in the monorepo. Enforces formatting for studio package and fixes indirection in controlplane

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.19%. Comparing base (177a1c0) to head (473a53d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2599       +/-   ##
===========================================
- Coverage   63.29%   38.19%   -25.11%     
===========================================
  Files         244      778      +534     
  Lines       25757   116297    +90540     
  Branches        0     8176     +8176     
===========================================
+ Hits        16303    44417    +28114     
- Misses       8087    71518    +63431     
+ Partials     1367      362     -1005     

see 1022 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Aenimus Aenimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@comatory comatory enabled auto-merge (squash) March 6, 2026 14:43
Copy link
Copy Markdown
Contributor

@wilsonrivera wilsonrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Aenimus Aenimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going do this in a more incremental and manageable way. Discussing elsewhere.

Comment thread shared/test/testdata/routerConfig.json
Comment thread shared/.prettierignore Outdated
@comatory comatory force-pushed the ondrej/eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci branch from e55360c to 9f18c0b Compare March 6, 2026 15:26
@comatory comatory changed the title fix: formatting drift + CI improvements fix: configurations for prettier Mar 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 6, 2026

Walkthrough

CI workflows and linting configuration updated: added lint step to controlplane CI workflow, modified studio CI workflow to comment out active lint step, extended Prettier ignore patterns to exclude testdata directories, and updated controlplane emails build script to remove inline linting while extending ESLint to include .tsx files.

Changes

Cohort / File(s) Summary
CI Workflow Updates
.github/workflows/controlplane-ci.yaml, .github/workflows/studio-ci.yaml
Added lint & format step to controlplane workflow during email template generation phase; removed active lint step from studio workflow and added commented-out lint:fix alternative before git-dirty-check.
Prettier Configuration
.prettierignore, shared/.prettierignore
Extended Prettier ignore patterns to exclude testdata directories (**/testdata, test/testdata/*) and test snapshots (test/__snapshots__) across root and shared directories.
Build Configuration
controlplane/emails/package.json
Removed inline lint:fix invocation from build script; expanded ESLint extension list in lint:fix script to include .tsx alongside .ts, .mjs, .cjs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'fix: configurations for prettier' is vague and generic. It mentions Prettier configuration but doesn't convey the specific problem being solved (formatting drift and CI improvements). Update title to be more specific, such as 'fix: prettier and formatter configuration to prevent formatting drift' or 'fix: enforce formatting in CI and add prettier configurations'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comatory comatory requested review from Aenimus and endigma March 6, 2026 15:34
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/controlplane-ci.yaml:
- Around line 69-70: The CI step "Lint & format" currently runs "pnpm run
--filter ./controlplane/ lint:fix" which skips the controlplane/emails package;
update the workflow run command to include the emails workspace so its .tsx
linting runs too, e.g. add a second filter for "controlplane/emails" (use
multiple --filter flags) or run the workspace-wide script (pnpm -w run lint:fix)
so both controlplane and controlplane/emails lint:fix are executed; change the
run line accordingly in the "Lint & format" job.

In @.github/workflows/studio-ci.yaml:
- Around line 46-47: Re-enable the Studio lint step in the CI workflow by
restoring the commented job that runs "pnpm run --filter studio lint:fix" (or
switch to "pnpm run --filter studio lint" if you want a non-mutating check) so
that the studio package is explicitly linted/formatted before the
"git-dirty-check" gate; locate the commented block with the step name "Lint" and
update it to run the chosen command (lint or lint:fix) and ensure it appears
before the "git-dirty-check" step.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c2c5768e-6b48-44eb-aefb-3271912bc366

📥 Commits

Reviewing files that changed from the base of the PR and between 9ea1388 and 473a53d.

📒 Files selected for processing (5)
  • .github/workflows/controlplane-ci.yaml
  • .github/workflows/studio-ci.yaml
  • .prettierignore
  • controlplane/emails/package.json
  • shared/.prettierignore

Comment thread .github/workflows/controlplane-ci.yaml
Comment thread .github/workflows/studio-ci.yaml
Copy link
Copy Markdown
Member

@Aenimus Aenimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (for real this time)

@comatory comatory merged commit dc6dc2d into main Mar 6, 2026
24 checks passed
@comatory comatory deleted the ondrej/eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci branch March 6, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants