Skip to content

fix: re-enable linting in CI (studio)#2638

Merged
comatory merged 1 commit intomainfrom
eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci-pt6
Mar 12, 2026
Merged

fix: re-enable linting in CI (studio)#2638
comatory merged 1 commit intomainfrom
eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci-pt6

Conversation

@comatory
Copy link
Copy Markdown
Contributor

@comatory comatory commented Mar 12, 2026

Summary by CodeRabbit

  • Chores
    • Enabled automated linting checks in the CI/CD pipeline to enforce code quality standards.

Checklist

Re-enables linting in CI for studio to avoid formatting drift

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2026

Walkthrough

The Lint step in the CI workflow was uncommented and activated to run pnpm run --filter studio lint:fix during the build pipeline, replacing the previously commented-out variant.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/studio-ci.yaml
Activated the Lint step by uncommenting the block and removing the commented-out variant (net: +2/-2 lines).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: re-enable linting in CI (studio)' clearly and concisely summarizes the main change: uncommenting and activating the Lint step in the studio CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comatory comatory force-pushed the eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci-pt6 branch from 77e04c6 to 63fd9c4 Compare March 12, 2026 05:46
@comatory comatory marked this pull request as ready for review March 12, 2026 05:46
@comatory comatory requested review from a team as code owners March 12, 2026 05:46
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/studio-ci.yaml (1)

32-33: Pre-existing issue: Cache path references web/ instead of studio/.

The Next.js cache path is configured as ${{ github.workspace }}/web/.next/cache but the studio component is in studio/. This means the cache is likely not being utilized correctly.

This isn't part of your PR changes, but you may want to fix it while you're working on this workflow:

        path: |
-          ${{ github.workspace }}/web/.next/cache
+          ${{ github.workspace }}/studio/.next/cache
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/studio-ci.yaml around lines 32 - 33, The workflow's cache
path uses the incorrect workspace subdirectory string '${{ github.workspace
}}/web/.next/cache' so the studio Next.js cache isn't used; update the YAML
"path" value to reference the studio subdirectory (replace '.../web/.next/cache'
with the equivalent '.../studio/.next/cache' string) and verify any other cache
entries or steps that reference "web/.next/cache" are similarly updated to
"studio/.next/cache" so the CI caches the correct build artifacts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/studio-ci.yaml:
- Around line 32-33: The workflow's cache path uses the incorrect workspace
subdirectory string '${{ github.workspace }}/web/.next/cache' so the studio
Next.js cache isn't used; update the YAML "path" value to reference the studio
subdirectory (replace '.../web/.next/cache' with the equivalent
'.../studio/.next/cache' string) and verify any other cache entries or steps
that reference "web/.next/cache" are similarly updated to "studio/.next/cache"
so the CI caches the correct build artifacts.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a059914f-9848-4c32-aa1f-80c0d69c5c9a

📥 Commits

Reviewing files that changed from the base of the PR and between 8aaff6c and 63fd9c4.

📒 Files selected for processing (1)
  • .github/workflows/studio-ci.yaml

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 1.59%. Comparing base (8aaff6c) to head (63fd9c4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2638   +/-   ##
=====================================
  Coverage   1.59%   1.59%           
=====================================
  Files        296     296           
  Lines      41472   41472           
  Branches     432     432           
=====================================
  Hits         662     662           
  Misses     40524   40524           
  Partials     286     286           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comatory comatory enabled auto-merge (squash) March 12, 2026 06:50
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@comatory comatory merged commit 73a7e73 into main Mar 12, 2026
12 checks passed
@comatory comatory deleted the eng-9087-cosmostudioci-fix-formatting-drift-enforce-formatting-in-ci-pt6 branch March 12, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants