Shortwave radiation balance at the wall missing reflected direct and diffuse radiation reflection from the wall terms. #2100
Closed
joshi994 wants to merge 6 commits intowrf-model:masterfrom
Closed
Shortwave radiation balance at the wall missing reflected direct and diffuse radiation reflection from the wall terms. #2100joshi994 wants to merge 6 commits intowrf-model:masterfrom
joshi994 wants to merge 6 commits intowrf-model:masterfrom
Conversation
… 2 (wrf-model#2078) TYPE: bug fix KEYWORDS: radar DA DESCRIPTION OF CHANGES: Problem: Duplicated allocation of avg_qws when choosing radar_rhv_opt = 2. da_free_unit instead of da_get_unit for closing a file when radar_rhv_opt is equal to 2. ISSUE: wrf-model#2077 LIST OF MODIFIED FILES: var/da/da_radar/da_get_innov_vector_radar.inc
TYPE: text only KEYWORDS: namelists, corrections SOURCE: JiriRichter and internal DESCRIPTION OF CHANGES: The description of a few namelists are updated. io_style_emiss is removed from this file since it is for WRF-Chem, and not specifiable under &time_control. Namelist ntiedtke_dx_opt was also removed, since it is not implemented. ISSUE: For use when this PR closes an issue. Fixes wrf-model#2071, wrf-model#2072, wrf-model#2073 LIST OF MODIFIED FILES: run/README.namelist RELEASE NOTE: The documentation of a few namelists is updated in this PR.
…rf-model#2032) TYPE: Bug fix KEYWORDS: LECH stability functions, Latent heat flux, Sensible heat flux, SL Urban Canpy Model SOURCE: Parag Joshi (Brookhaven National Lab), Katia Lamer (Brookhaven National Lab) DESCRIPTION OF CHANGES: Problem: The stability functions originally proposed by Lech Lobocki which are used in calculating the exchange coefficients between surface layer and roof, building wall, Green roof, and ground are implemented incorrectly. The error surfaced while comparing the formulation suggested in Lobocki 1992 with the equations in commands/lines 3056 and 3062 (WRF-v4.5.2). Solution: The code has been corrected by referring to the equations 48 and 49 of the article "A procedure for the derivation of surface layer bulk relationships from simplified second-order closure models" by Lobocki 1992 (Journal of Applied Meteorology). LIST OF MODIFIED FILES: M phys/module_sf_urban.F TESTS CONDUCTED: 1. The significance of the corrections can be highlighted by comparing a test run with the corrected module and current version of the WRF model. 2. The fix will correct the evaluation of the exchange coefficients between the ground, roof, green roof etc and air. 3. The Jenkins tests are all passing. RELEASE NOTE: Lech's stability functions are corrected following the original formulation in the single layer urban canopy model.
…nt. (wrf-model#2049) TYPE: Bug fix KEYWORDS: PV panels, Correlations, Upward heat flow, BEM (Building Energy Model). SOURCE: Parag Joshi (Brookhaven National Laboratory) DESCRIPTION OF CHANGES: Problem: A typographical mistake was identified within the correlations that evaluate heat transfer coefficient for the upward heat flow over PV panels in the Building Energy Model (BEM). Solution: The parameters have been modified following the correlation expressions provided in the literature. Please refer to the equation J.2.2a on page number 79 of the document below: https://nvlpubs.nist.gov/nistpubs/Legacy/IR/nbsir83-2655.pdf LIST OF MODIFIED FILES: M phys/module_sf_bem.F TESTS CONDUCTED: 1. No test has been conducted as the parameters seems to have very small or insignificant impact on the results. However, the tests can be performed with and without correcting the parameters to quantify the role. 2. The Jenkins tests are all passing. RELEASE NOTE: Bug fixes for parameters associated with the heat transfer coefficient for the upward heat flow over PV panels.
…urban model (wrf-model#2038) TYPE: Bug fix KEYWORDS: Stability function, Urban canopy model, surface energy balance, Green roof temperature. SOURCE: Parag Joshi (Brookhaven National Laboratory), Katia Lamer (Brookhaven National Laboratory) DESCRIPTION OF CHANGES: Problem: The calculations for PSIM in the mos subroutine of module-sf_urban.F has been corrected. The earlier equations has a typo where X (= (1-16\zeta)^1/4) is mentioned instead of X0. In addition, following the formulation of surface energy balance of OSU1DPBL scheme by Ek and Mahrt 1991, it appears that when the following definition is used $\sigma * \theta_s^4 = \sigma T_0^4 (1 + 4((\theta_s - T_0)/T_0)))$ is used, the temperature in the calculations of net flux at the surface should use T_0 (temperature at first atmospheric level). However, in the module TGRP (temperature of the green roof surface at previous time step is used)is used instead of T_0 (please refer to the attached screenshots of the formulation). Solution: Following the formulation, the temperature variable has been updated according. Moreover, the mos subroutine is also corrected by replacing X by X0 where X0 is =X*z0/(z+z0) (as per the WRF/phys/module_sf_urban.F). LIST OF MODIFIED FILES: M phys/module_sf_urban.F TESTS CONDUCTED: 1. No tests are conducted. A test case could be run to compare the impact of changes in the TGR and stability parameter value as well as CD, US, and ALPHA. 2. The Jenkins tests are all passing. RELEASE NOTE: Fixes for the calculations for PSIM in the mos subroutine and the temperature used in surface energy balance for the green roof. The later follows the OSU1DPBL document located at: [https://ftp.emc.ncep.noaa.gov/mmb/gcp/ldas/nceplsm/OSU1DPBL/OSU1DPBL-userguide.pdf]
…RF-CMAQ (wrf-model#2044) TYPE: bug fix KEYWORDS: metadata, global attributes, auxiliary output, auxiliary history, WRF-CMAQ SOURCE: Tanya Spero and Jeff Willison (U.S. EPA) DESCRIPTION OF CHANGES: Problem: The suite of global attributes is incomplete in auxiliary history files. Notably, the precipitation tipping bucket is among the fields not included. Separately, there is no metadata in the header to indicate when WRF-CMAQ is used. Solution: Changes are introduced in share/output_wrf.F to expand the use cases to write the full suite of global attributes to the metadata of auxiliary output files. In addition, two global attributes are added to the output only when the WRF-CMAQ model is invoked (WRF_CMAQ_OPTION and DIRECT_SW_FEEDBACK). ISSUE: Fixes wrf-model#1476 LIST OF MODIFIED FILES: share/output_wrf.F TESTS CONDUCTED: 1. Tests were conducted using the WRF model both with and without compiling with CMAQ. The base code was pulled from the branch "release-v4.6.0" on 8 May 2024. In both sets of tests on the EPA supercomputing system, an auxiliary output file was created in auxhist7. The global attributes were properly expanded to include the full suite of attributes in the auxiliary output file. The two new WRF-CMAQ coupled model attributes appeared when the WRF-CMAQ model was invoked. 2. The Jenkins tests are all passing. RELEASE NOTE: Expanded global attributes to the full suite for auxiliary history files. Also added two global attributes when the WRF-CMAQ model is invoked (WRF_CMAQ_OPTION and DIRECT_SW_FEEDBACK).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cenlinhe
In this pull request, we corrected the shortwave radiation balance at the wall, particularly the reflected direct and diffuse radiation reaching the wall. A couple of terms that represent contribution from the reflected radiation from walls were absent in the code. We followed the formulations (equation 8 from Kusaka at. al. (2001))and corrected the shortwave radiation balance.
TYPE: Bug fix
KEYWORDS: Shortwave radiation balance, reflected radiation, shadowing effect, single-layer urban canopy model (SLUCM), direct and diffuse radiation.
SOURCE: Parag Joshi, Katia Lamer (Brookhaven National Laboratory)
DESCRIPTION OF CHANGES:
Problem:
The single-layer urban canopy model missed a couple of terms that represent the direct and diffuse radiation reaching at a wall reflected from the other wall. It leads to an inaccurate calculation of the shortwave radiation at the walls.
Solution:
Mathematical formulation by Kusaka et. al. (2001) was followed to verify the equations used in the SLUCM module in WRF. The equations are corrected.
ISSUE: For use when this PR closes an issue.
Fixes #123
LIST OF MODIFIED FILES: module_sf_urban.F
TESTS CONDUCTED:
RELEASE NOTE: Contribution from the reflected direct and diffuse shortwave radiation from the wall was missing in the code. Present pull request fix the error which leads to underestimation of SWR at the wall.