Updated heat transfer coefficient correlation parameters for horizontal and upward heat flow over PV panels.

[joshi994]

TYPE: Bug fix

KEYWORDS: PV panels, Correlations, Upward heat flow, BEM (Building Energy Model).

SOURCE: Parag Joshi (Brookhaven National Laboratory)

DESCRIPTION OF CHANGES:
Problem:
A typographical mistake was identified within the correlations that evaluate heat transfer coefficient for the upward heat flow over PV panels in the Building Energy Model (BEM).

Solution:
The parameters have been modified following the correlation expressions provided in the literature. Please refer to the equation J.2.2a (please see the attached screenshot) on page number 79 of the document below.
https://nvlpubs.nist.gov/nistpubs/Legacy/IR/nbsir83-2655.pdf

LIST OF MODIFIED FILES:
M phys/module_sf_bem.F

TESTS CONDUCTED:

1. No test has been conducted as the parameters seems to have very small or insignificant impact on the results. However, the tests can be performed with and without correcting the parameters to quantify the role.
2. The Jenkins tests are all passing.

RELEASE NOTE: Bug fixes for parameters associated with the heat transfer coefficient for the upward heat flow over PV panels.

[weiwangncar]

The regression test results:
Test Type | Expected | Received | Failed
= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Number of Tests : 23 24
Number of Builds : 60 57
Number of Simulations : 158 150 0
Number of Comparisons : 95 86 0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

[weiwangncar]

@joshi994 Please hold off any update to this PR or any new PR, as we are going to update the regression tests in the next few weeks. Thanks!

[dudhia]

This PR is to master and should go to develop until we have a 4.6.1 branch

[weiwangncar]

@cenlinhe Can you review this PR?

[cenlinhe]

While I am reviewing this, I would also like the original developer @andreazonato to take a look and confirm this bug fix.

[weiwangncar]

@andreazonato Can you review this PR? Thanks!

[andreazonato]

Sorry for the late reply, I was on holidays.

Yes, I think this PR solves the bug.

I agree! Thanks.

Andrea

[cenlinhe]

I approve this fix.