Bugfix for duplicated allocation and file closing for radar_rhv_opt = 2

[mos3r3n]

Bugs fix of duplicated allocation and file close in radar_rhv_opt = 2.

TYPE: bug fix

KEYWORDS: radar DA

DESCRIPTION OF CHANGES:
Problem:
Duplicated allocation of avg_qws when choosing radar_rhv_opt = 2.
da_free_unit instead of da_get_unit for closing a file when radar_rhv_opt is equal to 2.

ISSUE: #2077

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
var/da/da_radar/da_get_innov_vector_radar.inc

[weiwangncar]

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

[liujake]

@weiwangncar @islas Is it ok to merge this bugfix to 4.6.1?

[islas]

Removal of line 278 seems good, but the change to use da_free_unit seems to be separate from the rest of the PR. If these two lines are two different bug fixes it'd be best if they were split into different PRs.

[liujake]

Is it Ok to keep this single PR, but change the PR title (and content) to reflect there are 2 bugs fixed? Seems better to me to keep one single PR as changes are in one single file.

[islas]

I can see the argument for single PR if both are necessary to get radar_rhv_opt = 2 to work. In that case I think a more concise title to capture both would be something along the lines of "Bugfixes for radar DA when using radar_rhv_opt = 2" where the description notes both.

[mos3r3n]

small bug fix of duplicated allocation in radar_rhv_opt = 2.

Hi, @islas. Both bugs are related to radar_rhv_opt = 2. I have updated the title and descriptions to make it clear. With both bug fixes, the radar_rhv_opt = 2 could work properly. Therefore, it cloud be better to merge both bugs in this PR.