Clean up redundant code, Registry checks + improvements, and simplification of certain defines#1899
Closed
islas wants to merge 20 commits intowrf-model:developfrom
Closed
Clean up redundant code, Registry checks + improvements, and simplification of certain defines#1899islas wants to merge 20 commits intowrf-model:developfrom
islas wants to merge 20 commits intowrf-model:developfrom
Conversation
Collaborator
Author
|
@weiwangncar @dudhia Here are the separated changes from #1896 that modify existing files that have no dependency on new system and can ultimately be categorized as improvement/bug fixes rather than new feature. |
Collaborator
|
The regression test results: |
Merged
This was referenced Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: make, cleanup, duplicates
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Fixes to various issues found while redesigning build system that are independent of new build system features. These bug fixes include removal of duplicate files, wrong #ifdefs, simplified ifdefs (no impact), poor Fortran syntax requiring sed or standard.exe for fixes, relying on autogen in-situ code where alternative coding practice suffices. No or few checks in Registry where checks would be incredibly useful for debugging purposes.
Solution:
Removal of dead/duplicate/obfuscating code and consolidating logic & makefiles to make use of changes. Slight rework of # defines. Checks on Registry generation with ability to run generation of files outside of repository.
LIST OF MODIFIED FILES:
M .gitignore
M dyn_em/module_advect_em.F
M dyn_em/module_first_rk_step_part1.F
M external/atm_ocn/cmpcomm.F
M external/io_adios2/wrf_io.F90
M external/io_grib1/Makefile
D external/io_grib1/wrf_status_codes.h
M external/io_grib2/g2lib/dec_png.c
M external/io_grib2/g2lib/enc_png.c
M external/io_grib_share/Makefile
D external/io_grib_share/wrf_io_flags.h
D external/io_grib_share/wrf_status_codes.h
M external/io_int/io_int.F90
M external/io_int/io_int_idx.c
M external/io_int/makefile
M external/io_netcdf/wrf_io.F90
M external/io_netcdfpar/wrf_io.F90
M external/io_pnetcdf/wrf_io.F90
M external/ioapi_share/wrf_status_codes.h
M frame/module_configure.F
M frame/module_internal_header_util.F
M frame/module_io_quilt_old.F
M inc/intio_tags.h
M phys/module_mp_SBM_polar_radar.F
M phys/module_mp_fast_sbm.F
M tools/gen_allocs.c
M tools/gen_streams.c
M tools/reg_parse.c
M tools/registry.c
TESTS CONDUCTED:
RELEASE NOTE:
Various bug fixes & small improvements in code maintenance such as runtime checks on Registry generation, simplified # defines, removal of redundant code