Runtime checks on registry file generation and add ability to run out-of-source#1909
Closed
islas wants to merge 4 commits intowrf-model:developfrom
Closed
Runtime checks on registry file generation and add ability to run out-of-source#1909islas wants to merge 4 commits intowrf-model:developfrom
islas wants to merge 4 commits intowrf-model:developfrom
Conversation
Collaborator
Author
|
@dudhia @weiwangncar |
Collaborator
|
The regtest results: |
Collaborator
|
I'd suggest splitting this PR into three separate PRs:
|
Collaborator
Author
Will close this one and open new ones shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: registry, out-of-source
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Registry code generation continues regardless of errors and missing fields are not caught until sometimes ~40 minutes into compilation when a subsequent source file is missing registry-generated fields. Additionally, the generated code clutters the source development environment with hundreds of files, requiring many .gitignore entries that seem counterintuitive (e,g. ignoring all *.f90 source files). Finally, there is a bug in the the gen_allocs conditionally compiled code
Solution:
Check returns of
gen_...()functions that create files to output if respective call failed to generate the registry codeAdd the ability to supply a root registry directory to utilize instead of assumed relative directories to allow out-of-source registry code generation outside of the WRF repo. Make assumed relative still the default method so previous builds not using this new capability still work.
Fix gen_allocs.c define macro
LIST OF MODIFIED FILES:
M tools/gen_allocs.c
M tools/gen_streams.c
M tools/reg_parse.c
M tools/registry.c
TESTS CONDUCTED:
RELEASE NOTE:
Runtime checks on registry file generation and add ability to run out-of-source. Minor bug fix in gen_allocs.c