Skip to content

Removal of redundant code files wrf_status_codes.h, wrf_io_flags.h, io_int_idx_tags.h#1911

Merged
islas merged 6 commits intowrf-model:developfrom
islas:redundantCodeRemoval
Jan 5, 2024
Merged

Removal of redundant code files wrf_status_codes.h, wrf_io_flags.h, io_int_idx_tags.h#1911
islas merged 6 commits intowrf-model:developfrom
islas:redundantCodeRemoval

Conversation

@islas
Copy link
Collaborator

@islas islas commented Aug 15, 2023

TYPE: bug fix

KEYWORDS: maintenance, cleanup, duplicates

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Several uses of redundant code exist in WRF that convolute the build process, notably :

  • wrf_status_codes.h
  • wrf_io_flags.h
  • io_int_idx_tags.h
    This leads to multiple definitions in various places with potential for conflicting or ambiguous usage throughout the build.

Solution:
Remove duplicate files and consolidate usage to single sources of truth for each file. Adjust source files & build rules that use the respective files

LIST OF MODIFIED FILES:
M external/io_grib1/Makefile
D external/io_grib1/wrf_status_codes.h
M external/io_grib_share/Makefile
D external/io_grib_share/wrf_io_flags.h
D external/io_grib_share/wrf_status_codes.h
M external/io_int/io_int.F90
M external/io_int/io_int_idx.c
M external/io_int/makefile
M external/ioapi_share/wrf_status_codes.h
M frame/module_internal_header_util.F
M frame/module_io_quilt_old.F
M inc/intio_tags.h

TESTS CONDUCTED:

  1. Do mods fix problem? Local tests pass and compile without duplicate code and without generating duplicate code
  2. Are the Jenkins tests all passing? Yes

RELEASE NOTE:
Removal of redundant code files wrf_status_codes.h, wrf_io_flags.h, io_int_idx_tags.h

@islas islas requested review from a team as code owners August 15, 2023 22:25
@islas
Copy link
Collaborator Author

islas commented Aug 15, 2023

@dudhia @weiwangncar
At the suggesting of @mgduda I've split #1899 into more digestible PRs addressing individual issues

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@islas islas merged commit 3a0478e into wrf-model:develop Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants