Removal of redundant code files wrf_status_codes.h, wrf_io_flags.h, io_int_idx_tags.h#1911
Merged
islas merged 6 commits intowrf-model:developfrom Jan 5, 2024
Merged
Conversation
Collaborator
Author
|
@dudhia @weiwangncar |
Collaborator
|
The regression test results: |
mgduda
approved these changes
Jan 5, 2024
smileMchen
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: maintenance, cleanup, duplicates
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Several uses of redundant code exist in WRF that convolute the build process, notably :
This leads to multiple definitions in various places with potential for conflicting or ambiguous usage throughout the build.
Solution:
Remove duplicate files and consolidate usage to single sources of truth for each file. Adjust source files & build rules that use the respective files
LIST OF MODIFIED FILES:
M external/io_grib1/Makefile
D external/io_grib1/wrf_status_codes.h
M external/io_grib_share/Makefile
D external/io_grib_share/wrf_io_flags.h
D external/io_grib_share/wrf_status_codes.h
M external/io_int/io_int.F90
M external/io_int/io_int_idx.c
M external/io_int/makefile
M external/ioapi_share/wrf_status_codes.h
M frame/module_internal_header_util.F
M frame/module_io_quilt_old.F
M inc/intio_tags.h
TESTS CONDUCTED:
RELEASE NOTE:
Removal of redundant code files wrf_status_codes.h, wrf_io_flags.h, io_int_idx_tags.h