MP38 Thompson 2-mom graupel/hail#1667
Conversation
|
@mefrediani Did you receive an email from Jenkins test? If you did, please post the summary here. If you did not, can you follow the instruction shown here so that it may increase your chance receiving the email? Once you've revised the setup, could you make a small, non-consequential change (such as remove an empty line, spaces, etc.) so that another Jenkins test may be triggered? Thanks. |
|
@weiwangncar I followed the instruction and made a small change to the code as you described but I still haven't received the email. I searched my inbox and found the jenkins test result from the firebrand_spotting PR but not from this one. Is it possible that I haven't received it because it's still a draft PR? |
|
@weiwangncar I changed the PR status to ready for review and it ran 5 checks but when I click to see the details. it takes me to a page that says "site can't be reached" on this address: https://ncar_jenkins.scalacomputing.com/job/WRF-Prod-with-label/100/console. |
|
@mefrediani Thanks for trying. I am supposed to receive an email too, but I didn't. I'm trying to see if we can resolve this issue. We really need to see the results from the test email to know if the code has succeeded. In the meantime, if you can try to a bit-for-bit test and a restart time manually, that would be greatly appreciated. You can find the instructions on our Wiki page. |
|
#1667 has passed the regular tests. Is there another problem you can see,
@weiwangncar?
…On Tue, Feb 8, 2022 at 10:02 AM weiwangncar ***@***.***> wrote:
@mefrediani <https://github.com/mefrediani> Thanks for trying. I am
supposed to receive an email too, but I didn't. I'm trying to see if we can
resolve this issue. We really need to see the results from the test email
to know if the code has succeeded. In the meantime, if you can try to a
bit-for-bit test and a restart time manually, that would be greatly
appreciated. You can find the instructions on our Wiki
<https://github.com/wrf-model/WRF/wiki> page.
—
Reply to this email directly, view it on GitHub
<#1667 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77G3UKUSZ7ZC4SL3T5LU2FEDLANCNFSM5NTBFMXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@weiwangncar it seems that there's an issue with the Noah LSM and I had to create new input files to try a different surface scheme. I'll send you an update on that soon. If it helps, the issue when sf_surface_physics=2 is described below. While using sf_surface_physics=2, the identical results test using the -d executable was crashing in the LSM, so I compiled the develop branch with the latest commit (a49fe58), also using -d, and it also crashed with the same error (see below). For the restart test, I got a difference in variable that seems to be unrelated with the microphysics scheme: SFROFF. I wonder if it also relates to the LSM... ./diffwrf mp38-restart/wrfout_d01_2018-12-13_07:00:00 mp38-restart/write_restart/wrfout_d01_2018-12-13_07:00:00 SegFault with -d compilation (develop branch): Program received signal SIGSEGV: Segmentation fault - invalid memory reference. Backtrace for this error: |
|
@mefrediani Thanks for testing these two functions. You may want to wait for us to sort out some PRs to address Noah LSM, for example (see PR#1668). |
|
@weiwangncar @dudhia @gthompsnWRF Here's the bit for bit test results: ./diffwrf mp38-write-restart/wrfout_d01_2018-12-13_07:00:00 mp38-from-restart/wrfout_d01_2018-12-13_07:00:00 ./diffwrf mp38-b4b-serial/wrfout_d01_2018-12-13_06:05:00 mp38-b4b-mpi/wrfout_d01_2018-12-13_06:05:00 You can access the files on /glade/scratch/frediani/Relampago/runs/tests in these folders: |
|
@mefrediani Thanks for doing the bit-for-bit and restart tests. Regarding your reg tests, I got the information from Scala who provides the computing resources for the tests. I received some output from them. The first group of tests the code failed on is for WRF-Chem - the code did not compile. If you never compiled WRF-Chem, see instructions provided on this page, scroll down the page, and following the links provided by the 'Code Preparation and Testing Requirements' near the bottom of the page. |
|
Is this one for V4.4 because it is not labeled that way yet? |
|
@dudhia It is labeled for develop branch. |
We would love to make it possible for inclusion into V4.4 - I realize there has been some conversation about this. |
|
As this new option overlaps a lot with the older options, tests need to be done on those to make sure that there are no unexpected changes to results. |
@dudhia Please let me know what tests you'd like me to run. |
|
Yes, and add a separate call.
…On Tue, Feb 15, 2022 at 10:30 AM Maria Frediani ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In phys/module_diagnostics_driver.F
<#1667 (comment)>:
> @@ -493,6 +493,8 @@ SUBROUTINE diagnostics_driver ( grid, config_flags, &
,QG_CURR=moist(ims,kms,jms,P_QG) &
,QR_CURR=moist(ims,kms,jms,P_QR) & ! gthompsn
,NR_CURR=scalar(ims,kms,jms,P_QNR) & ! gthompsn
+ ,NG_CURR=scalar(ims,kms,jms,P_QNG) & ! THOMPSONGH
+ ,QVOLG_CURR=scalar(ims,kms,jms,P_QVOLG) & ! THOMPSONGH
@dudhia <https://github.com/dudhia> should I separate the THOMPSONGH CASE
statement from THOMPSON and THOMPSONAERO?
—
Reply to this email directly, view it on GitHub
<#1667 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77G2YWQU72GC6CECETTU3KESFANCNFSM5NTBFMXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Mainly the older Thompson options before and after this addition.
…On Tue, Feb 15, 2022 at 10:32 AM Maria Frediani ***@***.***> wrote:
As this new option overlaps a lot with the older options, tests need to be
done on those to make sure that there are no unexpected changes to results.
@dudhia <https://github.com/dudhia> Please let me know what tests you'd
like me to run.
—
Reply to this email directly, view it on GitHub
<#1667 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77BAXON5OUFHBUJE5OLU3KEZPANCNFSM5NTBFMXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@dudhia are you referring to the modifications you requested specifically for the module_diagnostics_driver? Because some of the modifications made for this PR (mp=38) will affect the results of the old thompson (mp=8 and 28), as described in the PR, so the results will not be identical. Cloud you please clarify? @weiwangncar I believe I fixed the issue affecting the WRF-Chem compilation. Could you please let me know? |
|
@weiwangncar @kkeene44 I wasn't able to push the code fixes after the new develop merge. I ended up using git difftool to create new commits on top of 8fe2a9c. The content of these commits are a bit scrambled in that the code modification is disorganized. I hope that's not an issue. |
|
@mefrediani It looks like you were able to push a commit. I will forward the test output to you. |
|
I can't resolve the conflicts that originated after merging with v4.4. I rebased this branch to 9c1d3cc (develop) to start over but I can't push it: |
If you're sure you want to overwrite the remote branch, you can add |
|
Do I start a new PR? It looks like I'm not able to reopen it because the branch was "force-pushed or recreated" |
|
@mefrediani It is better to start a new PR. |
|
@mefrediani Some of the conflict may be due to the update in the submodule code. Normally you may be able to update your local branch by doing something like 'git fetch upstream' followed by 'git pull upstream develop' (here upstream points to wrf-model/WRF). But with submodule, you may need to do an additional step to update the code in the submodule: git submodule update --init --recursive (from WRF/ directory). Looking at the files changed at this point, it shows you have some differences from the submodule in WRF/phys/noahmp/, and not doing 'git submodule update' may be the cause. |
|
@mefrediani If you'd like to give this a try, I can re-open the PR for you. |
|
Sure, I can try that. Thanks, Wei. |
|
@mefrediani It doesn't look that I can re-open this PR. |
|
The message is that the mp38 branch was recreated, so it can't re-open. You may need to find the original code and do another PR from it. |
|
That's ok. I'll start another PR. Thanks for trying :) |
Option to compute two-moment prognostics for graupel/hail TYPE: enhancement, new feature KEYWORDS: microphysics, Thompson microphysics, graupel, hail, double-moment SOURCE: Code developed by Greg Thompson (JCSDA, UCAR) and Anders Jensen (RAL, NCAR). Implemented in WRF v4.4 by Maria Frediani (RAL, NCAR) DESCRIPTION OF CHANGES: This code update includes a package to compute two-moment prognostics for graupel/hail and a predicted density graupel category (mp_physics=38); an update to the Y-intercept relationship for one-moment graupel; and it replaces air temperature for wet-bulb temperature in riming and mixed phase processes. Problem: One-dimensional graupel/hail growth does not couple to the storm dynamics and is insufficient for predicting more detailed microphysical storm characteristics and hazards such as hail size, density, and fall speed, which can be used to provide guidance on the timing and spatial extent of damaging hail. Sensitivity studies have shown that using a constant intercept parameter and a constant density can significantly constrain predicted hail size: simulated storms either produced only pea-size or baseball-size hail (Gilmore et al. 2004). Improving the representation of riming and mixed phase processes leads to improvements in predicted storm dynamics and propagation speed through microphysical feedbacks and also improves the spatial distribution and type of precipitation at the surface. Solution: Changes related with the new package mp_physics=38 include: Variable density for graupel (rho_g) Parameters become a function of rho_g (am_g, av_g, bv_g, cge, cgg, oamg) Extra dimension in lookup tables to account for graupel variable density (rho_g) New source/sink terms for 3-moment graupel Computation of radar reflectivity and nwp diagnostics using graupel volume mixing ratio Additional modifications affecting mp_physics=8 and mp_physics=28 include: Fall speed power law relations (av_i from 1847.5 to 1493.9) Reduced dimension of cse, csg (from 18 to 17) Use of wet-bulb temperature for riming and mixed-phase process Modified relationship for the Y-intercept of one-moment graupel to shift the properties of the graupel category to become more hail-like, resulting in a category that represents both graupel and hail. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M phys/module_diag_nwp.F M phys/module_diagnostics_driver.F M phys/module_microphysics_driver.F M phys/module_mp_thompson.F M phys/module_physics_init.F TESTS CONDUCTED: 1. The modifications were initially demonstrated using the original development made for WRF v4.0 (Jensen et al 2021, under review, MWR-D-21-0319). The operational mp28, mp28 with modified graupel Y-intercept, and mp38 were evaluated for a case study during the PECAN campaign using observed hail sizes from storm reports and estimated from radar. The evaluation showed clear improvement of the simulated reflectivity values in the upper-levels of discrete storms, coinciding with a significant reduction in the areal extent of graupel aloft, also seen when using the updated one-moment scheme. The two-moment and predicted density graupel scheme was also better able to predict a wide variety of hail sizes at the surface, including large (>2-inch in diameter) hail that was observed during this case. The implementation for this develop branch (aiming at the release v4.4) was tested using a case study from the Relampago campaign and results from mp28, mp38-v4.0, mp38-develop-v4.4 were compared. This comparison indicates that the implementation was successful. 2. It passed regression tests. RELEASE NOTES: A package to compute two-moment prognostics for graupel/hail and a predicted density graupel category is added in the Thompson scheme (mp_physics=38); Other updates to the scheme include a change to the Y-intercept relationship for one-moment graupel; and replacement of air temperature for wet-bulb temperature in riming and mixed phase processes. The code requires a data file to run. This data file: qr_acr_qg_mp38V1.dat can be found on NCAR's computer under /glade/work/wrfhelp/WRF_files/, and online at http://www2.mmm.ucar.edu/wrf/src/wrf_files/. If you prefer to compute this file, set namelist write_thompson_mp38table = true. Note that it can take up to 18 min to compute this table using a 12-CPU job, 4 min on 128-CPU, and several hours if computed on a single CPU.
wrf-model#1808) Option to compute two-moment prognostics for graupel/hail TYPE: enhancement, new feature KEYWORDS: microphysics, Thompson microphysics, graupel, hail, double-moment SOURCE: Code developed by Greg Thompson (JCSDA, UCAR) and Anders Jensen (RAL, NCAR). Implemented in WRF v4.4 by Maria Frediani (RAL, NCAR) DESCRIPTION OF CHANGES: This code update includes a package to compute two-moment prognostics for graupel/hail and a predicted density graupel category (mp_physics=38); an update to the Y-intercept relationship for one-moment graupel; and it replaces air temperature for wet-bulb temperature in riming and mixed phase processes. Problem: One-dimensional graupel/hail growth does not couple to the storm dynamics and is insufficient for predicting more detailed microphysical storm characteristics and hazards such as hail size, density, and fall speed, which can be used to provide guidance on the timing and spatial extent of damaging hail. Sensitivity studies have shown that using a constant intercept parameter and a constant density can significantly constrain predicted hail size: simulated storms either produced only pea-size or baseball-size hail (Gilmore et al. 2004). Improving the representation of riming and mixed phase processes leads to improvements in predicted storm dynamics and propagation speed through microphysical feedbacks and also improves the spatial distribution and type of precipitation at the surface. Solution: Changes related with the new package mp_physics=38 include: Variable density for graupel (rho_g) Parameters become a function of rho_g (am_g, av_g, bv_g, cge, cgg, oamg) Extra dimension in lookup tables to account for graupel variable density (rho_g) New source/sink terms for 3-moment graupel Computation of radar reflectivity and nwp diagnostics using graupel volume mixing ratio Additional modifications affecting mp_physics=8 and mp_physics=28 include: Fall speed power law relations (av_i from 1847.5 to 1493.9) Reduced dimension of cse, csg (from 18 to 17) Use of wet-bulb temperature for riming and mixed-phase process Modified relationship for the Y-intercept of one-moment graupel to shift the properties of the graupel category to become more hail-like, resulting in a category that represents both graupel and hail. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M phys/module_diag_nwp.F M phys/module_diagnostics_driver.F M phys/module_microphysics_driver.F M phys/module_mp_thompson.F M phys/module_physics_init.F TESTS CONDUCTED: 1. The modifications were initially demonstrated using the original development made for WRF v4.0 (Jensen et al 2021, under review, MWR-D-21-0319). The operational mp28, mp28 with modified graupel Y-intercept, and mp38 were evaluated for a case study during the PECAN campaign using observed hail sizes from storm reports and estimated from radar. The evaluation showed clear improvement of the simulated reflectivity values in the upper-levels of discrete storms, coinciding with a significant reduction in the areal extent of graupel aloft, also seen when using the updated one-moment scheme. The two-moment and predicted density graupel scheme was also better able to predict a wide variety of hail sizes at the surface, including large (>2-inch in diameter) hail that was observed during this case. The implementation for this develop branch (aiming at the release v4.4) was tested using a case study from the Relampago campaign and results from mp28, mp38-v4.0, mp38-develop-v4.4 were compared. This comparison indicates that the implementation was successful. 2. It passed regression tests. RELEASE NOTES: A package to compute two-moment prognostics for graupel/hail and a predicted density graupel category is added in the Thompson scheme (mp_physics=38); Other updates to the scheme include a change to the Y-intercept relationship for one-moment graupel; and replacement of air temperature for wet-bulb temperature in riming and mixed phase processes. The code requires a data file to run. This data file: qr_acr_qg_mp38V1.dat can be found on NCAR's computer under /glade/work/wrfhelp/WRF_files/, and online at http://www2.mmm.ucar.edu/wrf/src/wrf_files/. If you prefer to compute this file, set namelist write_thompson_mp38table = true. Note that it can take up to 18 min to compute this table using a 12-CPU job, 4 min on 128-CPU, and several hours if computed on a single CPU.
5 participants
Option to compute two-moment prognostics for graupel/hail
TYPE: enhancement, new feature
KEYWORDS: microphysics, Thompson microphysics, graupel, hail, double-moment
SOURCE: Code developed by Greg Thompson (JCSDA, UCAR) and Anders Jensen (RAL, NCAR).
Implemented in WRF v4.4 by Maria Frediani (RAL, NCAR)
DESCRIPTION OF CHANGES:
This code update includes
Problem:
One-dimensional graupel/hail growth does not couple to the storm dynamics and is insufficient for predicting more detailed microphysical storm characteristics and hazards such as hail size, density, and fall speed, which can be used to provide guidance on the timing and spatial extent of damaging hail.
Sensitivity studies have shown that using a constant intercept parameter and a constant density can significantly constrain predicted hail size: simulated storms either produced only pea-size or baseball-size hail (Gilmore et al. 2004).
Improving the representation of riming and mixed phase processes leads to improvements in predicted storm dynamics and propagation speed through microphysical feedbacks and also improves the spatial distribution and type of precipitation at the surface.
Solution:
Changes related with the new package mp_physics=38 include:
Additional modifications affecting mp_physics=8 and mp_physics=28 include:
ISSUE: NA
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M phys/module_diag_nwp.F
M phys/module_diagnostics_driver.F
M phys/module_microphysics_driver.F
M phys/module_mp_thompson.F
M phys/module_physics_init.F
TESTS CONDUCTED:
The modifications were initially demonstrated using the original development made for WRF v4.0 (Jensen et al 2021, under review, MWR-D-21-0319). The operational mp28, mp28 with modified graupel Y-intercept, and mp38 were evaluated for a case study during the PECAN campaign using observed hail sizes from storm reports and estimated from radar. The evaluation showed clear improvement of the simulated reflectivity values in the upper-levels of discrete storms, coinciding with a significant reduction in the areal extent of graupel aloft, also seen when using the updated one-moment scheme. The two-moment and predicted density graupel scheme was also better able to predict a wide variety of hail sizes at the surface, including large (>2-inch in diameter) hail that was observed during this case.
The implementation for this develop branch (aiming at the release v4.4) was tested using a case study from the Relampago campaign and results from mp28, mp38-v4.0, mp38-develop-v4.4 were compared. This comparison indicates that the implementation was successful.
Yes, but I haven't received the emails.
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.