Bug fix for real*8 with Intel#11
Merged
kkeene44 merged 1 commit intowrf-model:masterfrom Oct 7, 2016
kkeene44:real_8_fix
Merged
Bug fix for real*8 with Intel#11kkeene44 merged 1 commit intowrf-model:masterfrom kkeene44:real_8_fix
kkeene44 merged 1 commit intowrf-model:masterfrom
kkeene44:real_8_fix
Conversation
…nd aer_ssa_opt, respectively. This was causing the real*8 regression tests to fail.
weiwangncar
approved these changes
Oct 7, 2016
Collaborator
weiwangncar
left a comment
weiwangncar
left a comment
There was a problem hiding this comment.
This looks good to me now. Thanks.
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 15, 2021
…on_method implementation of the cell perturation method (including momentum per…
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 13, 2022
FINO WRF setup
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: real*8, intel, WTF, regression
SOURCE: Internal
DESCRIPTION OF CHANGES:
In output_wrf.F, aer_asy_val was assigned to aer_asy_opt, and aer_ssa_val was assigned to aer_ssa_opt. Because a "val" is a real value, and an "opt" is an integer, this caused problems (NaN's) with the 64-bit tests during WTF testing. Made the correction.
LIST OF MODIFIED FILES:
M share/output_wrf.F
TESTS CONDUCTED: Ran a simple test with a real*8 compile to verify this corrects the problem. Regression test is now successful.