Check for VAR_SSO when using topo_wind#10
Merged
kkeene44 merged 1 commit intowrf-model:masterfrom Oct 7, 2016
kkeene44:VAR_SSO
Merged
Check for VAR_SSO when using topo_wind#10kkeene44 merged 1 commit intowrf-model:masterfrom kkeene44:VAR_SSO
kkeene44 merged 1 commit intowrf-model:masterfrom
kkeene44:VAR_SSO
Conversation
kkeene44
changed the title
…. VAR_SSO was not available in WPS version prior to V3.4. If using an older version of WPS to run a newer version of WRF, with the topo_wind option, this was problematic.
mkavulich
approved these changes
Oct 7, 2016
Contributor
mkavulich
left a comment
mkavulich
left a comment
There was a problem hiding this comment.
All of the mistakes that I made seem to be fixed. 👍
davegill
reviewed
Oct 17, 2016
| LOGICAL inval, retval | ||
| INTEGER comm, ierr | ||
| CALL wrf_get_dm_communicator(comm) | ||
| CALL mpi_allreduce ( inval, retval , 1, MPI_LOGICAL, MPI_LAND, comm, ierr ) |
Contributor
There was a problem hiding this comment.
@mkavulich @kkeene44
This line should be MPI_LOR not MPI_LAND. This is in the newly manufactured function wrf_dm_lor_logical.
dmey
added a commit
to TEB-model/wrf-teb
that referenced
this pull request
Mar 31, 2020
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 15, 2021
…_fix fix to surface layer on d01 when initializing nested domain
janmandel
added a commit
to wrf-sfire/WRF-SFIRE
that referenced
this pull request
Feb 5, 2022
janmandel
added a commit
to wrf-sfire/WRF-SFIRE
that referenced
this pull request
Feb 5, 2022
…el#10 previous default fire_wind_log_interp = 4 (with wind reduction factors) is obsolete and not parallel consistent, delete? wrf-model#23 Fixes wrf-model#13
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 13, 2022
commenting out suggested process configuration in sanity check namelist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: VAR_SSO, topo_wind
SOURCE: Internal
DESCRIPTION OF CHANGES:
Versions of WPS prior to V3.4 did not include VAR_SSO static data. This is necessary for running the topo_wind option in WRF (also introduced in version 3.4). If someone tries to use this option with a newer version of WRF, but with older WPS files, this causes problems, and we need this to cause a fatal error. Added a state variable to Registry.EM_COMMON called 'got_var_sso' (logical). Added a check in module_initialize_real.F to determine if var_sso is zero anywhere in the domain. If so, we set it to .true. Because we need to use a function in the module_initialize_real.F check that returns an 'OR' logical when looping through multiple processors, in module_dm.F, it was necessary to create a logical function called 'wrf_dm_lor_logical' that takes the input value and gives a return value (in the meantime, went ahead and added a similar function for an 'AND' logical in case it's needed in the future). Finally, added a check in start_em.F to make sure if using the topo wind option, VARSSO data is available. If not, it calls a fatal error and prints 'topo_wind requires VAR_SSO data'.
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M dyn_em/module_initialize_real.F
M dyn_em/start_em.F
M external/RSL_LITE/module_dm.F
TESTS CONDUCTED: Ran tests to verify that when using WPS data without VAR_SSO, with the topo_wind option, I get a fatal error specifying the reason. Regression test successful.