bug fix for WRF IO_QUILT

[smileMchen]

TYPE: bug fix

KEYWORDS: WRF IO_QUILT

SOURCE: internal (Dave)

DESCRIPTION OF CHANGES: The subroutine call was missing an argument, even though the argument is not used directly. The Cray compiler usually segfaults on this line (the code was wrong, the Cray compiler just indicated the error). If the quilting option was working for a user before this modification, it will continue to work after this modification (consistent with what was found with the regression tests, which do quilting

LIST OF MODIFIED FILES:
M frame/module_io_quilt_old.F

TESTS CONDUCTED: A nesting run with this fix is done to confirm this fix works. Regression is OK.

[davegill]

Ming,
Would you modify the commit message a bit.

1 The auto-correct with Mail is turning "get_nio_tasks_in_group" into "get_nil_tasks_in_group".

1. This is a bit too general to remind us what the change was for (in a few months): "The IO quilt wasn't working properly for nesting domains before this fix." Something like this maybe: "The subroutine call was missing an argument, even though the argument is not used directly. The Cray compiler usually segfaults on this line (the code was wrong, the Cray compiler just indicated the error). If the quilting option was working for a user before this mod, it will continue to work after this modification (consistent with what was found with the regression tests, which do quilting)."

Dave

[smileMchen]

Dave,

I just change this message on the website, but i am not sure whether it
goes out and replaces the old one. Please elt me know.

Thanks.

Ming

On 10/11/16 1:37 PM, Dave Gill wrote:

Ming,
Would you modify the commit message a bit.

1 The auto-correct with Mail is turning "get_nio_tasks_in_group" into
"get_nil_tasks_in_group".

1. This is a bit too general to remind us what the change was for (in
   a few months): "The IO quilt wasn't working properly for nesting
   domains before this fix." Something like this maybe: "The
   subroutine call was missing an argument, even though the argument
   is not used directly. The Cray compiler usually segfaults on this
   line (the code was wrong, the Cray compiler just indicated the
   error). If the quilting option was working for a user before this
   mod, it will continue to work after this modification (consistent
   with what was found with the regression tests, which do quilting)."

Dave

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/ARGf6aZoqgpC-7EMfjWpxTkU3O0pfcdMks5qy-VjgaJpZM4KT91Q.

[mkavulich]

Approved by dev committee