Skip to content

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 20, 2023

Related Issue #20860

Bump the deployment target to iOS 15 and remove the now redundant #available checks and the associated code.

To test: make sure it still compiles and runs (run some basic smoke tests)

Regression Notes

  1. Potential unintended areas of impact: n/a
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jun 20, 2023
@kean kean changed the title Task/ios 15 bumb deployment target Drop iOS 14 Support: Increase the deployment target to iOS 15 Jun 20, 2023
@kean kean changed the title Drop iOS 14 Support: Increase the deployment target to iOS 15 Drop iOS 14 Support: Increase deployment target to iOS 15 Jun 20, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 20, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20917-55b7b5c
Version22.6
Bundle IDorg.wordpress.alpha
Commit55b7b5c
App Center BuildWPiOS - One-Offs #6072
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 20, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20917-55b7b5c
Version22.6
Bundle IDcom.jetpack.alpha
Commit55b7b5c
App Center Buildjetpack-installable-builds #5098
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wrangling this @kean!

Base automatically changed from task/ios-15-update-uibutton-api-fnk1rmca to trunk June 20, 2023 20:05
@guarani guarani self-requested a review June 21, 2023 15:43
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the test plan only calls for the CI to be green. Do you think smoke testing of the build should be done? I'm not sure what testing has already been done.

With the next release being cut in on Monday (see PaaHJt-eZ-p2), I'm wondering if there's enough time this week for any issues related to the deployment target bump to be caught on the trunk branch.

@kean
Copy link
Contributor Author

kean commented Jun 21, 2023

I noticed the test plan only calls for the CI to be green. Do you think smoke testing of the build should be done? I'm not sure what testing has already been done.

I've been testing previous PRs individually, and I've also did quick regression testing yesterday.

With this PR, it's hard to pinpoint what areas to test, but I at least tested the main areas of the app.

I'm wondering if there's enough time this week for any issues related to the deployment target bump to be caught on the trunk branch.

I think it should be OK, but we could wait until Tuesday to merge it. There is no rush. But most of the related changes were already merged.

@kean kean force-pushed the task/ios-15-bumb-deployment-target branch from ab6c5a5 to 55b7b5c Compare June 21, 2023 22:02
@guarani guarani self-requested a review June 22, 2023 19:22
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing previous PRs individually, and I've also did quick regression testing yesterday.
With this PR, it's hard to pinpoint what areas to test, but I at least tested the main areas of the app.

Ok, I did a quick tap through the JP and WP app builds to try to catch regressions and had none.

I think it should be OK, but we could wait until Tuesday to merge it. There is no rush. But most of the related changes were already merged.

Ok, if we merge today there's only today and tomorrow to catch issues before the next beta (22.7). However, I don't see a big risk here as I've gone through the code changes and nothing looks out of place.

As for the actual deployment target change from 14 to 15, I can't think of any bugs that could come of that.

So, feel free to merge this week or next 👍

Thanks for your work, @kean!

@mokagio
Copy link
Contributor

mokagio commented Jun 23, 2023

Ok, if we merge today there's only today and tomorrow to catch issues before the next beta (22.7). However, I don't see a big risk here as I've gone through the code changes and nothing looks out of place.

On top of that, I would argue that only major issues would be noticed because we don't distribute nightly builds from trunk and don't have a mechanism for a large enough pool of folks using the app not smoke testing it to get their hands on these changes.

@kean
Copy link
Contributor Author

kean commented Jun 26, 2023

Hey, @guarani. The release branch was cut, so I'm planning to merge it today, and then I'll continue working on the remaining deprecations when I have time. I'm prioritizing the work on Blaze.

@kean kean merged commit 5edea71 into trunk Jun 26, 2023
@kean kean deleted the task/ios-15-bumb-deployment-target branch June 26, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants