-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drop iOS 14 Support: Increase deployment target to iOS 15 #20917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr20917-55b7b5c | |
Version | 22.6 | |
Bundle ID | org.wordpress.alpha | |
Commit | 55b7b5c | |
App Center Build | WPiOS - One-Offs #6072 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr20917-55b7b5c | |
Version | 22.6 | |
Bundle ID | com.jetpack.alpha | |
Commit | 55b7b5c | |
App Center Build | jetpack-installable-builds #5098 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for wrangling this @kean!
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/BlogDashboardViewController.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the test plan only calls for the CI to be green. Do you think smoke testing of the build should be done? I'm not sure what testing has already been done.
With the next release being cut in on Monday (see PaaHJt-eZ-p2), I'm wondering if there's enough time this week for any issues related to the deployment target bump to be caught on the trunk
branch.
I've been testing previous PRs individually, and I've also did quick regression testing yesterday. With this PR, it's hard to pinpoint what areas to test, but I at least tested the main areas of the app.
I think it should be OK, but we could wait until Tuesday to merge it. There is no rush. But most of the related changes were already merged. |
ab6c5a5
to
55b7b5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing previous PRs individually, and I've also did quick regression testing yesterday.
With this PR, it's hard to pinpoint what areas to test, but I at least tested the main areas of the app.
Ok, I did a quick tap through the JP and WP app builds to try to catch regressions and had none.
I think it should be OK, but we could wait until Tuesday to merge it. There is no rush. But most of the related changes were already merged.
Ok, if we merge today there's only today and tomorrow to catch issues before the next beta (22.7). However, I don't see a big risk here as I've gone through the code changes and nothing looks out of place.
As for the actual deployment target change from 14 to 15, I can't think of any bugs that could come of that.
So, feel free to merge this week or next 👍
Thanks for your work, @kean!
On top of that, I would argue that only major issues would be noticed because we don't distribute nightly builds from |
Hey, @guarani. The release branch was cut, so I'm planning to merge it today, and then I'll continue working on the remaining deprecations when I have time. I'm prioritizing the work on Blaze. |
Related Issue #20860
Bump the deployment target to iOS 15 and remove the now redundant #available checks and the associated code.
To test: make sure it still compiles and runs (run some basic smoke tests)
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.