Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Jun 21, 2023

Related Issue #20860

Remove MenuSheetViewController.swift which was a fallback for UIMenu on iOS 14. It should’ve been originally removed back in iOS 14 update but wasn't because of the incorrect #available(iOS 15, *) attribute (removed in #20917).

To test:

Moderation

  • Open the blog/site where you have right for moderation
  • Click “Context Menu”
  • Verify that the comments moderation menu is presented

No Moderation

  • Open the blog/site where you don't have the rights to moderate comments
  • Click “Share" button (displayed in the same place as the "Context Menu")
  • Verify that the share sheet is displayed

Here is why the code is, in fact, unused:

// In ReaderCommentsViewController.swift

// .menu overrides button's action
cell.accessoryButton.showsMenuAsPrimaryAction = isModerationMenuEnabled(for: comment)
cell.accessoryButton.menu = isModerationMenuEnabled(for: comment) ? menu(for: comment,
                                                                                     indexPath: indexPath,
                                                                                     handler: handler,
                                                                                     sourceView: cell.accessoryButton) : nil

Regression Notes

  1. Potential unintended areas of impact: comments moderation
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual testing
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jun 21, 2023
@kean kean changed the title Task/ios 15 remove menuviewcontroller Drop iOS 14 Support: Remove MenuSheetViewController Jun 21, 2023
@kean kean changed the base branch from trunk to task/ios-15-bumb-deployment-target June 21, 2023 22:33
@kean kean force-pushed the task/ios-15-remove-menuviewcontroller branch from a8da11c to b0d45eb Compare June 21, 2023 22:38
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20933-b0d45eb
Version22.6
Bundle IDorg.wordpress.alpha
Commitb0d45eb
App Center BuildWPiOS - One-Offs #6073
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20933-b0d45eb
Version22.6
Bundle IDcom.jetpack.alpha
Commitb0d45eb
App Center Buildjetpack-installable-builds #5099
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from task/ios-15-bumb-deployment-target to trunk June 26, 2023 20:06
@kean kean merged commit 1d26782 into trunk Jun 26, 2023
@kean kean deleted the task/ios-15-remove-menuviewcontroller branch June 26, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants