-
Couldn't load subscription status.
- Fork 1.1k
Comments: Add the new header component #20753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20753-df561e2 | |
| Version | 22.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | df561e2 | |
| App Center Build | jetpack-installable-builds #5118 |
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20753-df561e2 | |
| Version | 22.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | df561e2 | |
| App Center Build | WPiOS - One-Offs #6094 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me. The only change I think we could try is a lighter material :)
|
Bumping this to 22.7 because I'm starting the 22.6 code freeze today and this is still a draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked:
✅ Light/dark mode
✅ Different accessibility sizes
✅ VoiceOver
✅ RtL language
LGTM! ![]()
WordPress/Classes/ViewRelated/Comments/CommentTableHeaderView.swift
Outdated
Show resolved
Hide resolved
| @State var showsDisclosureIndicator = true | ||
|
|
||
| var body: some View { | ||
| if #available(iOS 15.0, *) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are hopefully going to be able to remove this (and VisualEffectView) soon. There is a discussion when to merge the deployment target bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, and looking forward to it! I'll create a follow-up PR to remove them once the version bump PR gets merged.


Refs #20568
This implements a new (SwiftUI!) header component for Comment screens. Currently, this is only shown in Reader comments when the feature flag is enabled. Here are some previews:
To test
Comment Moderation Updateflag is toggled on.Regression Notes
Potential unintended areas of impact
Should be none. The feature is hidden behind a feature flag.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: