Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget setup card updates after merge #2637

Merged

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Oct 2, 2024

Changes proposed in this Pull Request:

Closes #2502 .

Replace this with a good description of your changes & reasoning.

Additional details:

Changelog entry

changelog: none

jorgemd24 and others added 30 commits August 14, 2024 20:57
Fixed by running `npm run lint:js -- --fix`.
asvinb and others added 20 commits September 25, 2024 21:56
…ion-flow-2458-merged

2459 Campaign creation flow and 2458 merged
…creation-ccf-onboarding-merged

Merge onboarding improvements branch into consolidated ad
@asvinb asvinb requested a review from joemcgill October 2, 2024 17:36
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 34.74903% with 169 lines in your changes missing coverage. Please review.

Project coverage is 60.7%. Comparing base (ab2db99) to head (3ea1c12).
Report is 261 commits behind head on update/2502-budget-setup-card.

Files with missing lines Patch % Lines
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% 31 Missing and 4 partials ⚠️
...rc/components/paid-ads/ads-campaign/skip-button.js 0.0% 19 Missing and 1 partial ⚠️
js/src/data/resolvers.js 0.0% 13 Missing and 3 partials ⚠️
...ign/paid-ads-setup-sections/paid-ads-setup-form.js 0.0% 12 Missing and 2 partials ⚠️
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing ⚠️
...paid-ads-setup-sections/paid-ads-setup-sections.js 0.0% 9 Missing and 2 partials ⚠️
...c/components/paid-ads/billing-card/billing-card.js 14.3% 4 Missing and 2 partials ⚠️
...-ads/budget-section/budget-recommendation/index.js 0.0% 4 Missing and 2 partials ⚠️
js/src/hooks/useFetchBudgetRecommendation.js 16.7% 5 Missing ⚠️
js/src/components/app-tooltip/index.js 50.0% 3 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           update/2502-budget-setup-card   #2637     +/-   ##
===============================================================
- Coverage                           63.5%   60.7%   -2.7%     
===============================================================
  Files                                329     331      +2     
  Lines                               5117    5210     +93     
  Branches                            1238    1264     +26     
===============================================================
- Hits                                3249    3165     -84     
- Misses                              1695    1851    +156     
- Partials                             173     194     +21     
Flag Coverage Δ
js-unit-tests 60.7% <34.7%> (-2.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/attribute-mapping/index.js 100.0% <ø> (ø)
...ion/phone-number-card/verification-code-control.js 98.2% <100.0%> (-0.1%) ⬇️
...nts/free-ad-credit/country-modal/country-amount.js 100.0% <ø> (ø)
...c/components/free-ad-credit/country-modal/index.js 16.7% <ø> (ø)
js/src/components/free-ad-credit/index.js 11.1% <ø> (ø)
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <100.0%> (ø)
.../src/components/paid-ads/ads-campaign/constants.js 100.0% <ø> (ø)
...src/components/paid-ads/ads-campaign/faqs-panel.js 66.7% <100.0%> (ø)
... and 59 more

... and 19 files with indirect coverage changes

Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Let's go ahead and merge this and re review the original PR for #2502.

@joemcgill joemcgill merged commit f6f7ac3 into update/2502-budget-setup-card Oct 2, 2024
13 of 18 checks passed
@joemcgill joemcgill deleted the update/2502-budget-setup-card-updates branch October 2, 2024 19:51
@eason9487 eason9487 added changelog: none Skip changelog entry for this PR and removed changelog: update Big changes to something that wasn't broken. labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants