Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2459 Campaign creation flow and 2458 merged #2630

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Sep 30, 2024

Merge #2458 into #2459

dsawardekar and others added 30 commits August 9, 2024 08:05
dsawardekar and others added 21 commits September 5, 2024 13:26
…ithub.com:woocommerce/google-listings-and-ads into update/2490-hide-tax-rate-selection-ui-onboarding
…ore-registered

Log Exception if an asset is enqueued before being registered
Set WPCOM_API_STATUS transient for E2E tests
Release 2.8.5 - Merge `trunk` to `develop`
…nch-checklist-items

Remove pre launch checklist items
…nch-checklist

2492: Remove PreLaunchChecklist component
…election-ui-onboarding

Hide Tax UI during onboarding & keep in edit campaign
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 42 lines in your changes missing coverage. Please review.

Project coverage is 62.6%. Comparing base (9a612d3) to head (aa4329c).
Report is 201 commits behind head on feature/2459-campaign-creation-flow.

Files with missing lines Patch % Lines
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing ⚠️
js/src/components/app-tooltip/index.js 50.0% 3 Missing and 1 partial ⚠️
js/src/components/tree-select-control/index.js 78.6% 3 Missing ⚠️
...ute-mapping/attribute-mapping-delete-rule-modal.js 0.0% 1 Missing and 1 partial ⚠️
.../attribute-mapping/attribute-mapping-rule-modal.js 50.0% 1 Missing and 1 partial ⚠️
.../free-listings/setup-free-listings/form-content.js 0.0% 1 Missing and 1 partial ⚠️
...c/components/stepper/step-content-actions/index.js 33.3% 1 Missing and 1 partial ⚠️
js/src/components/tree-select-control/control.js 0.0% 1 Missing and 1 partial ⚠️
js/src/data/actions.js 50.0% 2 Missing ⚠️
...roduct-feed/review-request/review-request-modal.js 50.0% 2 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2630     +/-   ##
=====================================================================
- Coverage                                 63.8%   62.6%   -1.1%     
=====================================================================
  Files                                      326     319      -7     
  Lines                                     5089    5063     -26     
  Branches                                  1231    1232      +1     
=====================================================================
- Hits                                      3245    3171     -74     
- Misses                                    1676    1718     +42     
- Partials                                   168     174      +6     
Flag Coverage Δ
js-unit-tests 62.6% <68.4%> (-1.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/attribute-mapping/index.js 100.0% <ø> (ø)
...ion/phone-number-card/verification-code-control.js 98.2% <100.0%> (-0.1%) ⬇️
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <100.0%> (ø)
js/src/components/paid-ads/ads-campaign.js 0.0% <ø> (ø)
...components/paid-ads/asset-group/images-selector.js 100.0% <ø> (ø)
js/src/components/paid-ads/faqs-panel.js 66.7% <100.0%> (ø)
...rc/components/stepper/step-content-footer/index.js 50.0% <100.0%> (+16.7%) ⬆️
js/src/components/tree-select-control/tags.js 92.9% <100.0%> (ø)
... and 41 more

... and 14 files with indirect coverage changes

@joemcgill joemcgill marked this pull request as ready for review September 30, 2024 18:44
@joemcgill
Copy link
Collaborator

This is just handling merge conflicts from feature/2458-streamline-onboarding to this branch and updating feature/2459-campaign-creation-flow so with the upstream changes.

The merge conflict seemed to be handled correctly, so I'm merging these upstream changes to this feature branch so we can better see the changes that will be merged in #2632.

@joemcgill joemcgill merged commit 3d38d91 into feature/2459-campaign-creation-flow Sep 30, 2024
10 of 15 checks passed
@joemcgill joemcgill deleted the feature/2459-campaign-creation-flow-2458-merged branch September 30, 2024 18:46
@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants