Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Budget setup card updates after merge #2637

Merged
merged 260 commits into from
Oct 2, 2024

Restore complete campaign data from client session.

3ea1c12
Select commit
Loading
Failed to load commit list.
Merged

Budget setup card updates after merge #2637

Restore complete campaign data from client session.
3ea1c12
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 1s

60.7% (-2.7%) compared to ab2db99

View this Pull Request on Codecov

60.7% (-2.7%) compared to ab2db99

Details

Codecov Report

Attention: Patch coverage is 34.74903% with 169 lines in your changes missing coverage. Please review.

Project coverage is 60.7%. Comparing base (ab2db99) to head (3ea1c12).

Files with missing lines Patch % Lines
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% 31 Missing and 4 partials ⚠️
...rc/components/paid-ads/ads-campaign/skip-button.js 0.0% 19 Missing and 1 partial ⚠️
js/src/data/resolvers.js 0.0% 13 Missing and 3 partials ⚠️
...ign/paid-ads-setup-sections/paid-ads-setup-form.js 0.0% 12 Missing and 2 partials ⚠️
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing ⚠️
...paid-ads-setup-sections/paid-ads-setup-sections.js 0.0% 9 Missing and 2 partials ⚠️
...c/components/paid-ads/billing-card/billing-card.js 14.3% 4 Missing and 2 partials ⚠️
...-ads/budget-section/budget-recommendation/index.js 0.0% 4 Missing and 2 partials ⚠️
js/src/hooks/useFetchBudgetRecommendation.js 16.7% 5 Missing ⚠️
js/src/components/app-tooltip/index.js 50.0% 3 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           update/2502-budget-setup-card   #2637     +/-   ##
===============================================================
- Coverage                           63.5%   60.7%   -2.7%     
===============================================================
  Files                                329     331      +2     
  Lines                               5117    5210     +93     
  Branches                            1238    1264     +26     
===============================================================
- Hits                                3249    3165     -84     
- Misses                              1695    1851    +156     
- Partials                             173     194     +21
Files with missing lines Coverage Δ
js/src/attribute-mapping/index.js 100.0% <ø> (ø)
...ion/phone-number-card/verification-code-control.js 98.2% <100.0%> (-0.1%) ⬇️
...nts/free-ad-credit/country-modal/country-amount.js 100.0% <ø> (ø)
...c/components/free-ad-credit/country-modal/index.js 16.7% <ø> (ø)
js/src/components/free-ad-credit/index.js 11.1% <ø> (ø)
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <100.0%> (ø)
.../src/components/paid-ads/ads-campaign/constants.js 100.0% <ø> (ø)
...src/components/paid-ads/ads-campaign/faqs-panel.js 66.7% <100.0%> (ø)
... and 59 more

... and 19 files with indirect coverage changes

View more details on Codecov