libmamba: python multiversion support #36030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannf
added
the
approved-to-run
octo-sts
bot
added
the
bincapz/pass
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
pip builds need to find the .cmake files that will have been staged under
${{targets.destdir}} by the main package pipeline, which requires setting
the libmamba_DIR environment variable. When we were building in a 'run:'
stage, we just set that environment variable on the command line.
Unfortunately, no such facility seems to exist for the py/pip-build-install
pipeline. ${{X.Y}} variables are not expanded in an 'environment:' block.
So here use a 'run:' block to create python interpreter wrappers to set
this variable before calling the real interpreter.
We also no longer set CMAKE_PREFIX_PATH because files get installed
in the correct places without it.
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
dannf
force-pushed
the
multiversion/libmamba
branch
from
0cc8b5f to
576f443
Compare
Member
Author
|
Updating to a new upstream is blocked by #34953 |
justinvreeland
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/chainguard-dev/internal-dev/issues/5334