conda/py3-conda-libmamba-solver: python multiversioning #36456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dann frazier <[email protected]>
The package builds and tests fine without it now. Signed-off-by: dann frazier <[email protected]>
Use this more conventional naming scheme for python packages. This is a step towards python multiversioning. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
It fails testing: conda/conda#14439 Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
The package builds and tests fine without it now. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Avoids having to have explicit deps on very common things, and may add future proofing. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Move the test code into a variable to avoid code duplication. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
dannf
force-pushed
the
multiversion/py3-conda-libmamba-solver
branch
from
6d7d553 to
929df0a
Compare
dannf
added
the
approved-to-run
octo-sts
bot
added
the
bincapz/pass
smoser
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that libmambapy is multiversioned, we can move up the stack.
I started with
py3-conda-libmamba-solver, but found that it had dependencies onconda, which is really a python package in disguise, so I give it thepy3-treatment here.The other significant thing worth noting is that I abuse variables here to hold test code so I can share it between the main package and subpackages. I generally want to make sure tests work with each
py3.x-foo, but also want to make sure we didn't regress that test for users who are pulling in the legacy provides, and hate cut & pasting code. Another option we could consider is to put the tests in scripts outside of the YAML, similar to how we include local patches.Note: there's a pseudo-circular dependency here.
py3-conda-libmamba-solverusespy3-condafromcondain its test cases, andcondausespy3-conda-libmamba-solverat runtime.Also note that Python 3.13 support is currently blocked - upstream doesn't support it yet. I've filed and referenced the upstream issue.
See individual commit logs for details.